Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR: Add HTTPS handling and logging for LoxiLB based on --loxiURL co… #186

Merged
merged 3 commits into from
Oct 13, 2024

Conversation

sososo0
Copy link
Contributor

@sososo0 sososo0 commented Oct 11, 2024

Related Issue : #34

Summary

  • Checking --loxiURL in the config to determine HTTP or HTTPS
  • Handling HTTPS requests when making REST API calls
  • Logging when HTTPS is not supported in LoxiLB

…nfig

Signed-off-by: sohyun <sh0000@pusan.ac.kr>
@CLAassistant
Copy link

CLAassistant commented Oct 11, 2024

CLA assistant check
All committers have signed the CLA.

Copy link
Collaborator

@TrekkieCoder TrekkieCoder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look fine. However kube-loxilb README also need to be changed to mention about availability of https.

How has these changes been tested ?

@UltraInstinct14 UltraInstinct14 merged commit 85496b9 into loxilb-io:main Oct 13, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants