Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Programming exercises: Fix initial build on programming exercises imported from files #7329

Merged
merged 3 commits into from
Oct 14, 2023

Conversation

reschandreas
Copy link
Contributor

@reschandreas reschandreas commented Oct 5, 2023

Checklist

General

Server

  • Important: I implemented the changes with a very good performance and prevented too many (unnecessary) database calls.
  • I followed the coding and design guidelines.
  • I documented the Java code using JavaDoc style.

Changes affecting Programming Exercises

  • I tested all changes and their related features with all corresponding user types on Test Server 1 (Atlassian Suite).
  • I tested all changes and their related features with all corresponding user types on Test Server 2 (Jenkins and Gitlab).

Motivation and Context

Right now, importing a Programming Exercise from a file results in a failing build of the solution plan. (Because the build Is triggered before the exercise is fully imported). This PR fixes that and prevents confusion as the build plan is correctly run the first time and also passes instantly.

Description

Steps for Testing

Prerequisites:

  • 1 Instructor
  • 1 Programming Exercise exported previously
  1. Log in to Artemis
  2. Navigate to Course Administration
  3. Import a PE from a file, make sure the template plan fails as expected and the solution plan passes
  4. Create a new PE normally, make sure the template plan fails as expected and the solution plan passes
  5. Import a PE from another PE, make sure the template plan fails as expected and the solution plan passes

Review Progress

Performance Review

  • I (as a reviewer) confirm that the client changes (in particular related to REST calls and UI responsiveness) are implemented with a very good performance
  • I (as a reviewer) confirm that the server changes (in particular related to database calls) are implemented with a very good performance

Code Review

  • Code Review 1
  • Code Review 2

Manual Tests

  • Test 1
  • Test 2

Exam Mode Test

  • Test 1
  • Test 2

Test Coverage

Screenshots

before

Screenshot 2023-10-09 at 14 26 07

after

Screenshot 2023-10-09 at 14 26 23

@reschandreas reschandreas requested a review from a team as a code owner October 5, 2023 19:32
@github-actions github-actions bot added the server Pull requests that update Java code. (Added Automatically!) label Oct 5, 2023
@reschandreas reschandreas force-pushed the bugfix/fix-initial-build-on-pe-file-import branch from 84cb8ab to c1dfc3c Compare October 9, 2023 11:40
@reschandreas reschandreas temporarily deployed to artemis-test5.artemis.cit.tum.de October 9, 2023 15:03 — with GitHub Actions Inactive
Copy link
Contributor

@laurenzfb laurenzfb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested in testing session, worked as expected

Copy link
Contributor

@milljoniaer milljoniaer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested in testing session, worked as expected

@reschandreas reschandreas requested a review from aplr October 9, 2023 16:44
Copy link
Contributor

@aplr aplr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested in testing session, LGMT

Copy link
Contributor

@Strohgelaender Strohgelaender left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code

@terlan98 terlan98 temporarily deployed to artemis-test5.artemis.cit.tum.de October 9, 2023 17:11 — with GitHub Actions Inactive
Copy link
Contributor

@terlan98 terlan98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on TS5. Importing from file works only if the short name of the exercise is not changed. Changing the short name leads to the issue documented in #7188.

Copy link
Contributor

@laadvo laadvo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code lgtm

Copy link
Contributor

@tobias-lippert tobias-lippert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM

@krusche krusche merged commit 1be83a1 into develop Oct 14, 2023
48 of 52 checks passed
@krusche krusche deleted the bugfix/fix-initial-build-on-pe-file-import branch October 14, 2023 07:01
@krusche krusche added this to the 6.6.0 milestone Oct 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge server Pull requests that update Java code. (Added Automatically!) small
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants