-
Notifications
You must be signed in to change notification settings - Fork 297
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Development
: Skip build triggers for programming exercises during file imports
#7376
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In this second I wanted to create a PR with the same fix ^^
LGTM 👍
We still should rename |
@MaximilianAnzinger haha nice, yeah sorry for breaking it in the first place. The tests on my previous PR all went through without a problem. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
code LGTM
Development
: only set import to true if importing from a fileDevelopment
: Skip build triggers for programming exercises during file imports
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tests run trough and the parameter no longer has a confusing name.
Looks good to me
Checklist
General
Server
Changes affecting Programming Exercises
Motivation and Context
This PR fixes an issue introduced by #7329 that broke two server tests. The assumption in that PR was flawed and is now fixed, we only skip the triggers for the builds if we import an exercise from a file.
Description
Changed the name of the argument to make it clearer on how to use it and fixed it's usage.
Steps for Testing
Prerequisites:
Programming exercises
: Fix initial build on programming exercises imported from files #7329Review Progress
Performance Review
Code Review
Manual Tests
Exam Mode Test
Test Coverage
Screenshots