Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Development: Skip build triggers for programming exercises during file imports #7376

Merged
merged 3 commits into from
Oct 14, 2023

Conversation

reschandreas
Copy link
Contributor

@reschandreas reschandreas commented Oct 14, 2023

Checklist

General

Server

Changes affecting Programming Exercises

  • I tested all changes and their related features with all corresponding user types on Test Server 1 (Atlassian Suite).
  • I tested all changes and their related features with all corresponding user types on Test Server 2 (Jenkins and Gitlab).

Motivation and Context

This PR fixes an issue introduced by #7329 that broke two server tests. The assumption in that PR was flawed and is now fixed, we only skip the triggers for the builds if we import an exercise from a file.

Description

Changed the name of the argument to make it clearer on how to use it and fixed it's usage.

Steps for Testing

Prerequisites:

  • 1 Instructor
  • 2 Students
  • 1 Programming Exercise with Complaints enabled
  1. Run the server tests and check if all pass
  2. For functionality, refer to the testing steps from Programming exercises: Fix initial build on programming exercises imported from files #7329

Review Progress

Performance Review

  • I (as a reviewer) confirm that the client changes (in particular related to REST calls and UI responsiveness) are implemented with a very good performance
  • I (as a reviewer) confirm that the server changes (in particular related to database calls) are implemented with a very good performance

Code Review

  • Code Review 1
  • Code Review 2

Manual Tests

  • Test 1
  • Test 2

Exam Mode Test

  • Test 1
  • Test 2

Test Coverage

Screenshots

@reschandreas reschandreas requested a review from a team as a code owner October 14, 2023 12:26
@reschandreas reschandreas self-assigned this Oct 14, 2023
@github-actions github-actions bot added the server Pull requests that update Java code. (Added Automatically!) label Oct 14, 2023
Copy link
Collaborator

@MaximilianAnzinger MaximilianAnzinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In this second I wanted to create a PR with the same fix ^^

LGTM 👍

@MaximilianAnzinger
Copy link
Collaborator

We still should rename isImport to isFileImport

@reschandreas
Copy link
Contributor Author

@MaximilianAnzinger haha nice, yeah sorry for breaking it in the first place. The tests on my previous PR all went through without a problem.

Copy link
Contributor

@laurenzfb laurenzfb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code LGTM

@reschandreas reschandreas changed the title Development: only set import to true if importing from a file Development: Skip build triggers for programming exercises during file imports Oct 14, 2023
Copy link
Contributor

@JohannesStoehr JohannesStoehr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests run trough and the parameter no longer has a confusing name.
Looks good to me

@krusche krusche added this to the 6.6.0 milestone Oct 14, 2023
@krusche krusche merged commit 762f4f2 into develop Oct 14, 2023
23 of 28 checks passed
@krusche krusche deleted the development/fix-2-server-tests branch October 14, 2023 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready for review server Pull requests that update Java code. (Added Automatically!)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants