Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quiz exercises: Fix an issue in the export #8362

Merged
merged 2 commits into from
Apr 10, 2024
Merged

Conversation

muradium
Copy link
Contributor

@muradium muradium commented Apr 9, 2024

Checklist

General

Client

  • Important: I implemented the changes with a very good performance, prevented too many (unnecessary) REST calls and made sure the UI is responsive, even with large data.
  • I strictly followed the client coding and design guidelines.

Motivation and Context

Export button of a quiz exercise does not work on exercises management page. It happens because when all QuizExercises are fetched, they don't contain questions as they are redundant.

Description

I changed export function to fetch particular exercise before exporting to ensure it contains questions.

Steps for Testing

Prerequisites:

  • 1 Instructor
  • 1 Quiz Exercise
  1. Log in to Artemis as an Instructor
  2. Navigate to Course Management
  3. Create a Quiz Exercise
  4. Make sure you are on Exercises page and click the Export button of a Quiz. Download of a .json blob should start.

Testserver States

Note

These badges show the state of the test servers.
Green = Currently available, Red = Currently locked







Review Progress

Performance Review

  • I (as a reviewer) confirm that the client changes (in particular related to REST calls and UI responsiveness) are implemented with a very good performance

Code Review

  • Code Review 1
  • Code Review 2

Manual Tests

  • Test 1
  • Test 2

@muradium muradium requested a review from a team as a code owner April 9, 2024 15:44
Copy link

coderabbitai bot commented Apr 9, 2024

Walkthrough

The update enhances the export process for quiz exercises by ensuring the quiz exercise is fetched before exporting. This refinement improves the reliability and consistency of exporting quiz exercises, addressing potential issues with data integrity during the export process.

Changes

File Path Change Summary
.../quiz/manage/quiz-exercise-manage-buttons.component.ts Added HttpResponse import and modified exportQuizExercise method.

Possibly related issues

  • 'Exam': Bug importing exam #8006: The improvement in quiz exercise export functionality could indirectly help address the issue of missing quiz exercises when importing exams between courses by ensuring more reliable and complete data retrieval and export processes.
  • Missing Build plans of imported exercise #7439: While focusing on missing build plans for imported exercises, enhancing the export process could contribute to a more robust import/export mechanism, potentially mitigating related issues.

Recent Review Details

Configuration used: CodeRabbit UI

Commits Files that changed from the base of the PR and between 9d76b7f and 05bc019.
Files selected for processing (1)
  • src/main/webapp/app/exercises/quiz/manage/quiz-exercise-manage-buttons.component.ts (2 hunks)
Files skipped from review as they are similar to previous changes (1)
  • src/main/webapp/app/exercises/quiz/manage/quiz-exercise-manage-buttons.component.ts

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@github-actions github-actions bot added the client Pull requests that update TypeScript code. (Added Automatically!) label Apr 9, 2024
coderabbitai[bot]
coderabbitai bot previously approved these changes Apr 9, 2024
@krusche krusche added this to the 7.0.0 milestone Apr 9, 2024
@krusche krusche changed the title General: Fetch detailed quiz exercise info before exporting Quiz exercises: Fix an issue in the export Apr 9, 2024
…-buttons.component.ts

Co-authored-by: Lucas Welscher <ga53foy@mytum.de>
Copy link
Member

@julian-christl julian-christl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good, export works as specified on TS 2

@krusche krusche merged commit 7be9975 into develop Apr 10, 2024
37 of 44 checks passed
@krusche krusche deleted the bugfix/export-quiz-issue branch April 10, 2024 20:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
client Pull requests that update TypeScript code. (Added Automatically!)
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants