-
Notifications
You must be signed in to change notification settings - Fork 297
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Quiz exercises
: Fix an issue in the export
#8362
Conversation
WalkthroughThe update enhances the export process for quiz exercises by ensuring the quiz exercise is fetched before exporting. This refinement improves the reliability and consistency of exporting quiz exercises, addressing potential issues with data integrity during the export process. Changes
Possibly related issues
Recent Review DetailsConfiguration used: CodeRabbit UI Files selected for processing (1)
Files skipped from review as they are similar to previous changes (1)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
src/main/webapp/app/exercises/quiz/manage/quiz-exercise-manage-buttons.component.ts
Outdated
Show resolved
Hide resolved
General
: Fetch detailed quiz exercise info before exportingQuiz exercises
: Fix an issue in the export
…-buttons.component.ts Co-authored-by: Lucas Welscher <ga53foy@mytum.de>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks good, export works as specified on TS 2
Checklist
General
Client
Motivation and Context
Export button of a quiz exercise does not work on exercises management page. It happens because when all QuizExercises are fetched, they don't contain questions as they are redundant.
Description
I changed export function to fetch particular exercise before exporting to ensure it contains questions.
Steps for Testing
Prerequisites:
Testserver States
Note
These badges show the state of the test servers.
Green = Currently available, Red = Currently locked
Review Progress
Performance Review
Code Review
Manual Tests