-
Notifications
You must be signed in to change notification settings - Fork 297
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Exam mode
: Add summary to exam deletion dialog
#9185
Conversation
WalkthroughThe recent changes enhance the application’s exam management capabilities through new repository methods that support counting and retrieving related data. The exam deletion process has been improved with a summary report feature that aggregates important metrics. User interface components now offer contextual information during deletion actions, resulting in a more informed, user-friendly experience for managing exams. Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant ExamResource
participant ExamDeletionService
participant Database
User->>ExamResource: Request getDeletionSummary(courseId, examId)
ExamResource->>ExamDeletionService: Call getExamDeletionSummary(examId)
ExamDeletionService->>Database: Retrieve deletion metrics
Database-->>ExamDeletionService: Return metrics
ExamDeletionService-->>ExamResource: Provide summary data
ExamResource-->>User: Return deletion summary
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
Exam
: Add exam summary to exam deletion dialogUsability
: Add exam summary to exam deletion dialog
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 2
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 3
src/main/webapp/app/shared/delete-dialog/delete-dialog.component.html
Outdated
Show resolved
Hide resolved
src/main/java/de/tum/in/www1/artemis/web/rest/ExamResource.java
Outdated
Show resolved
Hide resolved
src/main/java/de/tum/in/www1/artemis/web/rest/ExamResource.java
Outdated
Show resolved
Hide resolved
Can you also include:
|
src/main/java/de/tum/in/www1/artemis/web/rest/ExamResource.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 6
src/main/webapp/app/shared/delete-dialog/delete-dialog.component.html
Outdated
Show resolved
Hide resolved
src/main/webapp/app/shared/delete-dialog/delete-dialog.component.html
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
code looks good 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works on Ts6
Tested just now in a test session. Summary of exam details looks good! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested on ts6, works as expected
Usability
: Add exam summary to exam deletion dialogExam mode
: Add summary to exam deletion dialog
Checklist
General
Server
Client
Motivation and Context
Implements #9179.
Description
Steps for Testing
Prerequisites:
Testserver States
Note
These badges show the state of the test servers.
Green = Currently available, Red = Currently locked
Click on the badges to get to the test servers.
Review Progress
Performance Review
Code Review
Manual Tests
Test Coverage
Screenshots
Summary by CodeRabbit
Summary by CodeRabbit
New Features
Bug Fixes
Documentation