Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exam mode: Add summary to exam deletion dialog #9185

Merged
merged 31 commits into from
Oct 12, 2024

Merge branch 'develop' into feature/summary-on-exam-deletion

8ce0b55
Select commit
Loading
Failed to load commit list.
Sign in for the full log view
Merged

Exam mode: Add summary to exam deletion dialog #9185

Merge branch 'develop' into feature/summary-on-exam-deletion
8ce0b55
Select commit
Loading
Failed to load commit list.
GitHub Actions / Junit Results failed Oct 12, 2024 in 0s

Junit Results

Junit Results ran 8197 in 1093.4679999999998 seconds 0 Errored, 3 Failed, 2 Skipped

Annotations

Check failure on line 0 in test

See this annotation in the file changed.

@github-actions github-actions / Junit Results

test#L0 

Junit Results ran 8197 in 1093.4679999999998 seconds 0 Errored, 3 Failed, 2 Skipped

Check failure on line 0 in /home/runner/work/Artemis/Artemis/src/test/java/de/tum/cit/aet/artemis/core/architecture/CoreRepositoryArchitectureTest.java

See this annotation in the file changed.

@github-actions github-actions / Junit Results

enforceUsageOfTestRepository() 

Junit test enforceUsageOfTestRepository() failed java.lang.AssertionError: Architecture Violation [Priority: MEDIUM] - Rule 'classes that reside in a package 'de.tum.cit.aet.artemis.core..' should not use repositories with subclasses, because Test Repositories should be used over production repositories, if such a repository exist.' was violated (1 times):
Test class de.tum.cit.aet.artemis.core.service.CourseServiceTest uses repository de.tum.cit.aet.artemis.programming.repository.BuildJobRepository which has subclasses: [JavaClass{name='de.tum.cit.aet.artemis.programming.test_repository.BuildJobTestRepository'}]
Raw output 
java.lang.AssertionError: Architecture Violation [Priority: MEDIUM] - Rule 'classes that reside in a package 'de.tum.cit.aet.artemis.core..' should not use repositories with subclasses, because Test Repositories should be used over production repositories, if such a repository exist.' was violated (1 times):
Test class de.tum.cit.aet.artemis.core.service.CourseServiceTest uses repository de.tum.cit.aet.artemis.programming.repository.BuildJobRepository which has subclasses: [JavaClass{name='de.tum.cit.aet.artemis.programming.test_repository.BuildJobTestRepository'}]
	at com.tngtech.archunit.lang.ArchRule$Assertions.assertNoViolation(ArchRule.java:94)
	at com.tngtech.archunit.lang.ArchRule$Assertions.check(ArchRule.java:86)
	at com.tngtech.archunit.lang.ArchRule$Factory$SimpleArchRule.check(ArchRule.java:165)
	at de.tum.cit.aet.artemis.shared.architecture.module.AbstractModuleRepositoryArchitectureTest.enforceUsageOfTestRepository(AbstractModuleRepositoryArchitectureTest.java:219)
	at java.base/java.lang.reflect.Method.invoke(Method.java:580)
	at java.base/java.util.concurrent.RecursiveAction.exec(RecursiveAction.java:194)
	at java.base/java.util.concurrent.ForkJoinTask.doExec(ForkJoinTask.java:387)
	at java.base/java.util.concurrent.ForkJoinPool$WorkQueue.topLevelExec(ForkJoinPool.java:1312)
	at java.base/java.util.concurrent.ForkJoinPool.scan(ForkJoinPool.java:1843)
	at java.base/java.util.concurrent.ForkJoinPool.runWorker(ForkJoinPool.java:1808)
	at java.base/java.util.concurrent.ForkJoinWorkerThread.run(ForkJoinWorkerThread.java:188)

Check failure on line 0 in /home/runner/work/Artemis/Artemis/src/test/java/de/tum/cit/aet/artemis/core/architecture/CoreResourceArchitectureTest.java

See this annotation in the file changed.

@github-actions github-actions / Junit Results

testNoOverrideOfEnforceAdmin() 

Junit test testNoOverrideOfEnforceAdmin() failed java.lang.AssertionError: Architecture Violation [Priority: MEDIUM] - Rule 'methods that are declared in classes that reside in a package 'de.tum.cit.aet.artemis.core..' and are declared in classes that are annotated with @EnforceAdmin should not be annotated with @EnforceAdmin and should not be meta-annotated with @PreAuthorize' was violated (2 times):
Method <de.tum.cit.aet.artemis.core.web.admin.AdminCourseResource.getDeletionSummary(long)> is annotated with @EnforceAdmin in (AdminCourseResource.java:194)
Method <de.tum.cit.aet.artemis.core.web.admin.AdminCourseResource.getDeletionSummary(long)> is meta-annotated with @PreAuthorize in (AdminCourseResource.java:194)
Raw output 
java.lang.AssertionError: Architecture Violation [Priority: MEDIUM] - Rule 'methods that are declared in classes that reside in a package 'de.tum.cit.aet.artemis.core..' and are declared in classes that are annotated with @EnforceAdmin should not be annotated with @EnforceAdmin and should not be meta-annotated with @PreAuthorize' was violated (2 times):
Method <de.tum.cit.aet.artemis.core.web.admin.AdminCourseResource.getDeletionSummary(long)> is annotated with @EnforceAdmin in (AdminCourseResource.java:194)
Method <de.tum.cit.aet.artemis.core.web.admin.AdminCourseResource.getDeletionSummary(long)> is meta-annotated with @PreAuthorize in (AdminCourseResource.java:194)
	at com.tngtech.archunit.lang.ArchRule$Assertions.assertNoViolation(ArchRule.java:94)
	at com.tngtech.archunit.lang.ArchRule$Assertions.check(ArchRule.java:86)
	at com.tngtech.archunit.lang.ArchRule$Factory$SimpleArchRule.check(ArchRule.java:165)
	at de.tum.cit.aet.artemis.shared.architecture.module.AbstractModuleResourceArchitectureTest.testNoOverrideOfEnforceAdmin(AbstractModuleResourceArchitectureTest.java:178)
	at java.base/java.lang.reflect.Method.invoke(Method.java:580)
	at java.base/java.util.concurrent.RecursiveAction.exec(RecursiveAction.java:194)
	at java.base/java.util.concurrent.ForkJoinTask.doExec(ForkJoinTask.java:387)
	at java.base/java.util.concurrent.ForkJoinPool$WorkQueue.topLevelExec(ForkJoinPool.java:1312)
	at java.base/java.util.concurrent.ForkJoinPool.scan(ForkJoinPool.java:1843)
	at java.base/java.util.concurrent.ForkJoinPool.runWorker(ForkJoinPool.java:1808)
	at java.base/java.util.concurrent.ForkJoinWorkerThread.run(ForkJoinWorkerThread.java:188)

Check failure on line 0 in /home/runner/work/Artemis/Artemis/src/test/java/de/tum/cit/aet/artemis/exam/architecture/ExamRepositoryArchitectureTest.java

See this annotation in the file changed.

@github-actions github-actions / Junit Results

enforceUsageOfTestRepository() 

Junit test enforceUsageOfTestRepository() failed java.lang.AssertionError: Architecture Violation [Priority: MEDIUM] - Rule 'classes that reside in a package 'de.tum.cit.aet.artemis.exam..' should not use repositories with subclasses, because Test Repositories should be used over production repositories, if such a repository exist.' was violated (3 times):
Test class de.tum.cit.aet.artemis.exam.ExamDeletionIntegrationTest uses repository de.tum.cit.aet.artemis.exam.repository.StudentExamRepository which has subclasses: [JavaClass{name='de.tum.cit.aet.artemis.exam.test_repository.StudentExamTestRepository'}]
Test class de.tum.cit.aet.artemis.exam.ExamDeletionIntegrationTest uses repository de.tum.cit.aet.artemis.programming.repository.BuildJobRepository which has subclasses: [JavaClass{name='de.tum.cit.aet.artemis.programming.test_repository.BuildJobTestRepository'}]
Test class de.tum.cit.aet.artemis.exam.util.ExamUtilService uses repository de.tum.cit.aet.artemis.communication.repository.PostRepository which has subclasses: [JavaClass{name='de.tum.cit.aet.artemis.communication.test_repository.PostTestRepository'}]
Raw output 
java.lang.AssertionError: Architecture Violation [Priority: MEDIUM] - Rule 'classes that reside in a package 'de.tum.cit.aet.artemis.exam..' should not use repositories with subclasses, because Test Repositories should be used over production repositories, if such a repository exist.' was violated (3 times):
Test class de.tum.cit.aet.artemis.exam.ExamDeletionIntegrationTest uses repository de.tum.cit.aet.artemis.exam.repository.StudentExamRepository which has subclasses: [JavaClass{name='de.tum.cit.aet.artemis.exam.test_repository.StudentExamTestRepository'}]
Test class de.tum.cit.aet.artemis.exam.ExamDeletionIntegrationTest uses repository de.tum.cit.aet.artemis.programming.repository.BuildJobRepository which has subclasses: [JavaClass{name='de.tum.cit.aet.artemis.programming.test_repository.BuildJobTestRepository'}]
Test class de.tum.cit.aet.artemis.exam.util.ExamUtilService uses repository de.tum.cit.aet.artemis.communication.repository.PostRepository which has subclasses: [JavaClass{name='de.tum.cit.aet.artemis.communication.test_repository.PostTestRepository'}]
	at com.tngtech.archunit.lang.ArchRule$Assertions.assertNoViolation(ArchRule.java:94)
	at com.tngtech.archunit.lang.ArchRule$Assertions.check(ArchRule.java:86)
	at com.tngtech.archunit.lang.ArchRule$Factory$SimpleArchRule.check(ArchRule.java:165)
	at de.tum.cit.aet.artemis.shared.architecture.module.AbstractModuleRepositoryArchitectureTest.enforceUsageOfTestRepository(AbstractModuleRepositoryArchitectureTest.java:219)
	at java.base/java.lang.reflect.Method.invoke(Method.java:580)
	at java.base/java.util.concurrent.RecursiveAction.exec(RecursiveAction.java:194)
	at java.base/java.util.concurrent.ForkJoinTask.doExec(ForkJoinTask.java:387)
	at java.base/java.util.concurrent.ForkJoinPool$WorkQueue.topLevelExec(ForkJoinPool.java:1312)
	at java.base/java.util.concurrent.ForkJoinPool.scan(ForkJoinPool.java:1843)
	at java.base/java.util.concurrent.ForkJoinPool.runWorker(ForkJoinPool.java:1808)
	at java.base/java.util.concurrent.ForkJoinWorkerThread.run(ForkJoinWorkerThread.java:188)
View more details on GitHub Actions