Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DM-40192] Explicitly pass in S3 endpoint #114

Merged
merged 2 commits into from
Aug 3, 2023
Merged

[DM-40192] Explicitly pass in S3 endpoint #114

merged 2 commits into from
Aug 3, 2023

Commits on Aug 3, 2023

  1. [DM-40192] Explicitly pass in S3 endpoint 

    Apparently with boto the automatic and using environment variables
for the S3_ENDPOINT_URL only works and configures itself if you
are using aws.  Since for our case we're using our own S3, we
need to pass it in when constructing the client.

Also, fix an unneeded dependency on the test_links_errors_s3 test.
    @cbanek
    cbanek committed Aug 3, 2023
    Configuration menu
    Copy the full SHA
    f990361 View commit details
    Browse the repository at this point in the history

  2. [DM-40192] make update

    @cbanek
    cbanek committed Aug 3, 2023
    Configuration menu
    Copy the full SHA
    4967359 View commit details
    Browse the repository at this point in the history