Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add min and max values to key file #51

Closed
srearl opened this issue Nov 15, 2018 · 4 comments
Closed

add min and max values to key file #51

srearl opened this issue Nov 15, 2018 · 4 comments
Assignees
Labels
homog2.0 issues to be addressed with next homogenization

Comments

@srearl
Copy link
Contributor

srearl commented Nov 15, 2018

add expected values to key file, ultimately to be pulled out into a separate lookup table or other resource (but initially added to the key file v2 template for convenience). this will be a QC step in the homogenization script.

@srearl srearl added the homog2.0 issues to be addressed with next homogenization label Nov 15, 2018
@srearl
Copy link
Contributor Author

srearl commented Dec 4, 2018

@wwieder @piersond will need help with this one as I am not sure the parameters or the acceptable ranges

@wwieder
Copy link
Collaborator

wwieder commented Dec 4, 2018 via email

@wwieder
Copy link
Collaborator

wwieder commented Dec 6, 2018

This should be done, or at least good enough for starters. see
https://docs.google.com/spreadsheets/d/1l3u2bPgzxotFao3GHp_JOGK9YA_NELdP7dkAztPnyqk/edit?usp=sharing

@wwieder wwieder closed this as completed Dec 6, 2018
@wwieder
Copy link
Collaborator

wwieder commented Dec 6, 2018

added columns for definition and authority of variables too. Maybe Mark S. can help with this. Avni and ISCN would also be a good resource.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
homog2.0 issues to be addressed with next homogenization
Projects
None yet
Development

No branches or pull requests

3 participants