Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

disable breakpoints not working #213

Closed
morgoth990 opened this issue Nov 17, 2021 Discussed in #212 · 1 comment · Fixed by #216
Closed

disable breakpoints not working #213

morgoth990 opened this issue Nov 17, 2021 Discussed in #212 · 1 comment · Fixed by #216
Labels
bug Something isn't working

Comments

@morgoth990
Copy link
Contributor

Discussed in #212

luaG_breakpoint() at line 319 the op variable is equal LOP_BREAK also when enable is false:
uint8_t op = enable ? LOP_BREAK : LUAU_INSN_OP(p->code[i]);
should be:
uint8_t op = enable ? LOP_BREAK : LUAU_INSN_OP(p->debuginsn[i]);

@zeux zeux added the bug Something isn't working label Nov 17, 2021
@zeux
Copy link
Collaborator

zeux commented Nov 17, 2021

Thanks! Will be fixed with the release later this week.

@zeux zeux closed this as completed in #216 Nov 19, 2021
zeux added a commit that referenced this issue Nov 19, 2021
- Improve error recovery during type checking
- Initial (not fully complete) implementation for singleton types (RFC RFC: Singleton types #37)
- Implement a C-friendly interface for compiler (luacode.h)
- Remove C++ features from lua.h (removed default arguments from luau_load and lua_pushcfunction)
- Fix lua_breakpoint behavior when enabled=false
- Implement coroutine.close (RFC RFC: coroutine.close #88)

Note, this introduces small breaking changes in lua.h:

- luau_load env argument is now required, pass an extra 0
- lua_pushcfunction now must be called with 3 arguments; if you were calling it with 2 arguments, pass an extra NULL; if you were calling it with 4, use lua_pushcclosure.

These changes are necessary to make sure lua.h can be used from pure C - the future release will make it possible by adding an option to luaconf.h to change function name mangling to be C-compatible. We don't anticipate breaking the FFI interface in the future, but this change was necessary to restore C compatibility.

Closes #121
Fixes #213
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Development

Successfully merging a pull request may close this issue.

2 participants