Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add/optimise swatch-book/aperture/blend/eclipse (dark/light) mode/paint-roller icons and improve palette/brush metadata #1280

Merged
merged 22 commits into from
Jan 16, 2024
Merged

Add/optimise swatch-book/aperture/blend/eclipse (dark/light) mode/paint-roller icons and improve palette/brush metadata #1280

merged 22 commits into from
Jan 16, 2024

Conversation

danielbayley
Copy link
Member

@danielbayley danielbayley commented May 16, 2023 •
edited
Loading

swatch-book Alts:

Untitled Artboard 1@2x

@vercel
Copy link

vercel bot commented May 16, 2023

@danielbayley is attempting to deploy a commit to the Lucide Team on Vercel.

A member of the Team first needs to authorize it.

@github-actions
Copy link

github-actions bot commented May 16, 2023 •
edited
Loading

Added or changed icons

icons/blend.svgicons/eclipse.svgicons/paint-roller.svgicons/swatch-book.svgicons/aperture.svg

Preview cohesion icons/equal-square.svgicons/play-square.svgicons/x-square.svgicons/percent-square.svgicons/chevron-up-square.svg
icons/blend.svgicons/eclipse.svgicons/paint-roller.svgicons/swatch-book.svgicons/aperture.svg
icons/triangle.svgicons/wand-2.svgicons/arrow-down-square.svgicons/circle-slash.svgicons/timer-reset.svg
Preview stroke widths icons/blend.svgicons/eclipse.svgicons/paint-roller.svgicons/swatch-book.svgicons/aperture.svg
icons/blend.svgicons/eclipse.svgicons/paint-roller.svgicons/swatch-book.svgicons/aperture.svg
icons/blend.svgicons/eclipse.svgicons/paint-roller.svgicons/swatch-book.svgicons/aperture.svg
DPI Preview (24px) icons/blend.svgicons/eclipse.svgicons/paint-roller.svgicons/swatch-book.svgicons/aperture.svg
Icon X-rays icons/blend.svgicons/eclipse.svgicons/paint-roller.svgicons/swatch-book.svgicons/aperture.svg

@jguddas
Copy link
Member

jguddas commented May 16, 2023

Top left looks best to me, the simpler, the better.

@danielbayley @karsa-mistmere
Update icons/swatch-book.svg
bd3a677 
Co-authored-by: Karsa <contact@karsa.org>
@danielbayley danielbayley changed the title Add swatch-book icon/improve palette/brush icons metadata Add swatch-book/color-wheel icons and improve palette/brush icons metadata May 16, 2023
jguddas
jguddas reviewed May 16, 2023
View reviewed changes
icons/color-wheel.svg Outdated Show resolved Hide resolved
@danielbayley @jguddas
Update icons/color-wheel.svg
452bfac 
Co-authored-by: Jakob Guddas <github@jguddas.de>
@karsa-mistmere
Copy link
Member

Not sure about the name and use case for color wheel, I mean it's not going to be very colourful, is it? 😄

@ericfennis
Copy link
Member

I'm with @karsa-mistmere, I doubt the color-wheel 🤔 . Other one looks nice tho.

@danielbayley danielbayley force-pushed the color branch 3 times, most recently from ceae840 to baca945 Compare May 31, 2023 23:38
@github-actions github-actions bot added the 🫧 metadata Improved metadata label Jul 17, 2023
karsa-mistmere
karsa-mistmere requested changes Jul 17, 2023
View reviewed changes
icons/aperture-2.svg Outdated Show resolved Hide resolved
icons/aperture.svg Outdated Show resolved Hide resolved
icons/contrast-2.svg Outdated Show resolved Hide resolved
danielbayley and others added 2 commits July 17, 2023 15:54
@danielbayley
Fix aperture-2 optimisation
f3adf9b
@danielbayley @karsa-mistmere
Update icons/aperture.svg
ae982ad 
Co-authored-by: Karsa <contact@karsa.org>
@danielbayley danielbayley mentioned this pull request Jul 23, 2023
Open
@danielbayley danielbayley mentioned this pull request Aug 1, 2023
Closed
@danielbayley danielbayley mentioned this pull request Aug 17, 2023
Merged
karsa-mistmere
karsa-mistmere previously requested changes Aug 25, 2023
View reviewed changes
icons/aperture-2.svg Outdated
Copy link
Member

@karsa-mistmere karsa-mistmere Aug 25, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we come up with a better name for this that sets it apart?
See: https://lucide.dev/guide/design/icon-design-guide#naming-conventions

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@karsa-mistmere aperture-simple?

@karsa-mistmere karsa-mistmere removed their assignment Aug 25, 2023
@github-actions GitHub Actions
Copy link

This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 5 days.

@github-actions github-actions bot added the Stale label Jan 16, 2024
@ericfennis
Copy link
Member

Use cases:

  • aperture-2, same as aperture, not sure why we need another one.
  • blend, In a design program blending 2 colors.
  • circle-line-vertical, unknown
  • eclipse, In an application for a dark mode toggle.
  • paint-roller, In a design program, paint something with a color
  • swatch-book, color book in application

@ericfennis
Copy link
Member

I've removed circle-line-vertical and aperture-2, due to weak use cases. These can be added to the lab branch tho

@ericfennis ericfennis merged commit be3ccc8 into lucide-icons:main Jan 16, 2024
6 of 7 checks passed
@danielbayley danielbayley deleted the color branch January 16, 2024 15:46
@danielbayley
Copy link
Member Author

circle-line-vertical, unknown

@ericfennis Another way to represent contrast, or also another dark mode toggle…

danielbayley added a commit to danielbayley/lucide that referenced this pull request Jan 16, 2024
@danielbayley
Fix missing metadata
9ac957b 
From lucide-icons#1280.
ericfennis pushed a commit that referenced this pull request Jan 17, 2024
@danielbayley
Fix missing metadata (#1808)
7bfdb2f 
* Fix missing metadata

From #1280.

* Fix more missing metadata

From #1378.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ericfennis ericfennis ericfennis approved these changes

@karsa-mistmere karsa-mistmere karsa-mistmere left review comments

@jguddas jguddas Awaiting requested review from jguddas

Assignees
No one assigned
Labels
🎨 icon About new icons 🫧 metadata Improved metadata Stale
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@danielbayley @jguddas @karsa-mistmere @ericfennis