Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refine file/sticky-note[-*] icons/add file-dot (dotfile) icon #1378

Merged
merged 17 commits into from
Jan 16, 2024

Conversation

danielbayley
Copy link
Member

@danielbayley danielbayley commented Jun 21, 2023

Current file[-*] icons don’t make any sense, in that while the fold is a sharp corner, the rest of the file shape has 2px rounding. Also, the folded corner is currently 0.5px off-grid… This PR fixes these issues, while also freeing up a little extra space internally for other elements.

@danielbayley danielbayley changed the title Refine file[-*] icons Refine file/sticky-note[-*] icons Jun 22, 2023
@karsa-mistmere
Copy link
Member

karsa-mistmere commented Jun 23, 2023

When scaled up the corners look a bit funky, although the current icon also suffers somewhat from this issue.
Not totally sure, but maybe we could also add a 2px rounding to the top right corners?

image
image

@danielbayley
Copy link
Member Author

When scaled up the corners look a bit funky, although the current icon also suffers somewhat from this issue. Not totally sure, but maybe we could also add a 2px rounding to the top right corners?

@karsa-mistmere I would say that if you were to fold it in real life, the corner will be straight across… But as you’ve illustrated, none of them are currently strictly accurate…

Not sure what happened to the preview bot here 🤷🏻‍♂️

@ericfennis
Copy link
Member

@danielbayley @karsa-mistmere I redesigned these ones before and made the little triangle not align on the corners on purpose. That was because the little triangle looked too dense on 100% scale, so shifting it a bit It looked a bit bigger. But rounding the corners could be a nice solution.

Looks like the preview bot has a max of icons he can process 🤔

@karsa-mistmere
Copy link
Member

image
image
image

100% & 200% views of file outlines w/ 5×5px corner and 2px rounding at each point.

Co-authored-by: Jakob Guddas <github@jguddas.de>
@danielbayley danielbayley changed the title Refine file/sticky-note[-*] icons Refine file/sticky-note[-*] icons/add file-dot (dotfile) icon Aug 25, 2023
@ericfennis
Copy link
Member

Can we have the use-case for file-dot?

@github-actions github-actions bot added the Stale label Oct 1, 2023
@lucide-icons lucide-icons deleted a comment from github-actions bot Jan 5, 2024
Copy link

github-actions bot commented Jan 5, 2024

Added or changed icons

icons/file-sliders.svgicons/file-archive.svgicons/file-audio-2.svgicons/file-audio.svgicons/file-axis-3d.svgicons/file-badge-2.svgicons/file-badge.svgicons/file-bar-chart-2.svgicons/file-bar-chart.svgicons/file-box.svgicons/file-check-2.svgicons/file-check.svgicons/file-clock.svgicons/file-code-2.svgicons/file-code.svgicons/file-cog.svgicons/file-diff.svgicons/file-digit.svgicons/file-down.svgicons/file-heart.svgicons/file-image.svgicons/file-input.svgicons/file-json-2.svgicons/file-json.svgicons/file-key-2.svgicons/file-key.svgicons/file-line-chart.svgicons/file-lock-2.svgicons/file-lock.svgicons/file-minus-2.svgicons/file-minus.svgicons/file-output.svgicons/file-pen-line.svgicons/file-pen.svgicons/file-pie-chart.svgicons/file-plus-2.svgicons/file-plus.svgicons/file-question.svgicons/file-scan.svgicons/file-search-2.svgicons/file-search.svgicons/file-spreadsheet.svgicons/file-stack.svgicons/file-symlink.svgicons/file-terminal.svgicons/file-text.svgicons/file-type-2.svgicons/file-type.svgicons/file-up.svgicons/file-video-2.svgicons/file-video.svgicons/file-volume-2.svgicons/file-volume.svgicons/file-warning.svgicons/file-x-2.svgicons/file-x.svgicons/file.svgicons/files.svgicons/sticker.svgicons/sticky-note.svg

Preview cohesion icons/gantt-chart-square.svgicons/scissors-square.svgicons/message-square-code.svgicons/divide-square.svgicons/dot-square.svgicons/activity-square.svgicons/square-stack.svgicons/code-square.svgicons/key-square.svgicons/messages-square.svgicons/mouse-pointer-square.svgicons/square-user-round.svgicons/message-square-reply.svgicons/message-square-off.svgicons/message-square-warning.svgicons/chevron-up-square.svgicons/message-square-diff.svgicons/message-square-more.svgicons/square.svgicons/mouse-pointer-square-dashed.svgicons/equal-square.svgicons/kanban-square-dashed.svgicons/function-square.svgicons/plus-square.svgicons/pi-square.svgicons/message-square-text.svgicons/parking-square-off.svgicons/terminal-square.svgicons/asterisk-square.svgicons/arrow-down-square.svgicons/scissors-square-dashed-bottom.svgicons/message-square-dashed.svgicons/split-square-horizontal.svgicons/message-square-heart.svgicons/minus-square.svgicons/library-square.svgicons/chevron-right-square.svgicons/message-square-quote.svgicons/power-square.svgicons/check-square.svgicons/square-dashed-bottom-code.svgicons/split-square-vertical.svgicons/square-user.svgicons/message-square-plus.svgicons/arrow-down-right-square.svgicons/kanban-square.svgicons/arrow-up-right-square.svgicons/square-dashed-bottom.svgicons/message-square-share.svgicons/percent-square.svgicons/chevron-left-square.svgicons/arrow-up-left-square.svgicons/arrow-right-square.svgicons/menu-square.svgicons/check-square-2.svgicons/chevron-down-square.svgicons/arrow-left-square.svgicons/sigma-square.svgicons/pilcrow-square.svgicons/slash-square.svg
icons/file-sliders.svgicons/file-archive.svgicons/file-audio-2.svgicons/file-audio.svgicons/file-axis-3d.svgicons/file-badge-2.svgicons/file-badge.svgicons/file-bar-chart-2.svgicons/file-bar-chart.svgicons/file-box.svgicons/file-check-2.svgicons/file-check.svgicons/file-clock.svgicons/file-code-2.svgicons/file-code.svgicons/file-cog.svgicons/file-diff.svgicons/file-digit.svgicons/file-down.svgicons/file-heart.svgicons/file-image.svgicons/file-input.svgicons/file-json-2.svgicons/file-json.svgicons/file-key-2.svgicons/file-key.svgicons/file-line-chart.svgicons/file-lock-2.svgicons/file-lock.svgicons/file-minus-2.svgicons/file-minus.svgicons/file-output.svgicons/file-pen-line.svgicons/file-pen.svgicons/file-pie-chart.svgicons/file-plus-2.svgicons/file-plus.svgicons/file-question.svgicons/file-scan.svgicons/file-search-2.svgicons/file-search.svgicons/file-spreadsheet.svgicons/file-stack.svgicons/file-symlink.svgicons/file-terminal.svgicons/file-text.svgicons/file-type-2.svgicons/file-type.svgicons/file-up.svgicons/file-video-2.svgicons/file-video.svgicons/file-volume-2.svgicons/file-volume.svgicons/file-warning.svgicons/file-x-2.svgicons/file-x.svgicons/file.svgicons/files.svgicons/sticker.svgicons/sticky-note.svg
icons/moon-star.svgicons/package-open.svgicons/rat.svgicons/bell-off.svg

@ericfennis ericfennis merged commit ad90ee7 into lucide-icons:main Jan 16, 2024
6 of 7 checks passed
@danielbayley
Copy link
Member Author

Can we have the use-case for file-dot?

@ericfennis Missed this comment! Use case is to represent a .dotfile, of course…

@danielbayley danielbayley deleted the files branch January 16, 2024 16:25
danielbayley added a commit to danielbayley/lucide that referenced this pull request Jan 16, 2024
ericfennis pushed a commit that referenced this pull request Jan 17, 2024
* Fix missing metadata

From #1280.

* Fix more missing metadata

From #1378.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🎨 icon About new icons 🫧 metadata Improved metadata
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants