-
-
Notifications
You must be signed in to change notification settings - Fork 548
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refine file
/sticky-note
[-*
] icons/add file-dot
(dotfile) icon
#1378
Conversation
@karsa-mistmere I would say that if you were to fold it in real life, the corner will be straight across… But as you’ve illustrated, none of them are currently strictly accurate… Not sure what happened to the preview bot here 🤷🏻♂️ |
@danielbayley @karsa-mistmere I redesigned these ones before and made the little triangle not align on the corners on purpose. That was because the little triangle looked too dense on 100% scale, so shifting it a bit It looked a bit bigger. But rounding the corners could be a nice solution. Looks like the preview bot has a max of icons he can process 🤔 |
Co-authored-by: Jakob Guddas <github@jguddas.de>
file
/sticky-note
[-*
] iconsfile
/sticky-note
[-*
] icons/add file-dot
(dotfile) icon
Can we have the use-case for |
@ericfennis Missed this comment! Use case is to represent a |
Current
file
[-*
] icons don’t make any sense, in that while the fold is a sharp corner, the rest of the file shape has 2px rounding. Also, the folded corner is currently 0.5px off-grid… This PR fixes these issues, while also freeing up a little extra space internally for other elements.