ImGuiFileDialog to replace portable-file-dialogs #420
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update ImGUI to 1.90.9 Fix up all ImGUI interface changes Add the diff for the custom TFE widgets to contrib/
Add a GLAD-generated opengl loader to the OpenGL renderbackend, to remove the dependency on external GLEW. This should not be noticeable on Windows, but is beneficial on Linux for several reasons: - at build time, no system opengl libraries and headers are required. - TFE does no longer have any built-in OpenGL or windowing system dependecy, just SDL2. - at run time, OpenGL is loaded by the system SDL, which also handles all the ugly windowing system (X11/Wayland/KMS/...) and platform (Linux/BSD/...) stuff. Signed-off-by: Manuel Lauss <manuel.lauss@gmail.com>
|
Added Icons and a bit of coloring: |
A file dialog based completely on ImGUI: https://github.com/aiekick/ImGuiFileDialog to replace the portable-file-dialogs and give these dialogs the same look as the rest of the TFE Ui. Need to raise minimum C++ standard to C++17 since this relies on std::filesystem. Signed-off-by: Manuel Lauss <manuel.lauss@gmail.com>
|
I remember trying this in the past and not liking it as much, but the extra dependencies on Linux is a good point and it is more consistent in terms of UI. |
|
yeah it's not the prettiest interface but outside of the editor you're probably going to use it only once, on initial setup. My main motivation was to get tfe running on my kodi box which doesn't have any windowing system (i.e. runs directly on the DRM framebuffer) and now all including the editor is usable. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So here's a first stab at implementing ImGuiFileDialog (https://github.com/aiekick/ImGuiFileDialog) to generate the file/directory selection dialogs.
Applies on top of PR #418 (which updates ImGui to 1.90.9) / this PR comes with #418 included since I used it as development base, and the Dialog needs at least ImGui-1.90.5
The Dialog uses std::filesystem, which means a compiler with c++17 support is required.
At the moment it looks like this:
It can be resized, I've for now chosen minimum size of 640x480px (image above), any smaller and
interacting with it becomes tedious, I found myself first resizing it every time it opened.
I'll look into having Icons instead of [File]/[Dir] and maybe different colors for files and dirs.
Tested on Windows and Linux, including the Editor (but that might still have bugs).
While this is no big deal for windows, on linux this again reduces external dependencies (external dialog app), and tfe+editor fully work without any desktop environment.