Drop GLEW in favour of built-in GLAD #418
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Open
|
editor needs more imgui fixing |
Update ImGUI to 1.90.9 Fix up all ImGUI interface changes Add the diff for the custom TFE widgets to contrib/
|
I fixed up the non-opening modal windows in the editor. |
Add a GLAD-generated opengl loader to the OpenGL renderbackend, to remove the dependency on external GLEW. This should not be noticeable on Windows, but is beneficial on Linux for several reasons: - at build time, no system opengl libraries and headers are required. - TFE does no longer have any built-in OpenGL or windowing system dependecy, just SDL2. - at run time, OpenGL is loaded by the system SDL, which also handles all the ugly windowing system (X11/Wayland/KMS/...) and platform (Linux/BSD/...) stuff. Signed-off-by: Manuel Lauss <manuel.lauss@gmail.com>
|
I've also now tested this successfully on Windows as well. |
This was referenced Jul 13, 2024
|
I've split the 2 patches into separate PRs (with #421 to start) |
|
I don't have any specific attachment to GLEW (other than using it in several projects), so this seems fine. I will patch it in after the next release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Drop GLEW in favor of GLAD-generated built-in loader.
resolution) is now fully handled by SDL2, no more wayland workarounds necessary (i.e. Added workaround for GLEW on wayland #386 )
The GLAD loader is GL4.6, while TFE's minimum is still GL3.3;
the Anisotropy stuff, which is core GL4.5, has been wrapped around
availability of EXT_texture_filter_anisotropic (which most GL2
drivers support).
This PR also updates ImGUI to version 1.90.9 because after the current in-tree 1.72 it also dropped GLEW.
This should also fix #395 which was caused by TFE explicitly linking to an OpenGL library, which, after this PR, is no longer necessary.
After applying this PR, the dependencies change to:
i.e. no explicit dependency on OpenGL and windowing system, just SDL2.
Another nice sideeffect at least on Linux is that "zink" (OpenGL over Vulkan) also works now:
Performance on my radeon is about 66% of the direct opengl path.