-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Dear ImGUI to 1.90.9 #421
Conversation
Looks good, I will patch it in after the next release. |
- Update ImGUI to 1.90.9 17-jul-2024 - export the custom TFE widgets to a separate source file - Fix up all ImGUI interface changes Signed-off-by: Manuel Lauss <manuel.lauss@gmail.com>
I went over the patch once again, the Editor, esp. the Modal Popups should be working again, and rebased it on top of master. This version of ImGui has problems(?) with Modal Popups that you also want to have a close button on. So I dropped this parameter from every Modal Popup and instead added a "Close" Button at the bottom. |
Annoying but good to know. I will merge this in before moving on further with the editor. My plan, originally, was to just stick with the version of ImGui so I could modify it to further suite the project - but this makes sense to remove GLEW and the file dialogs (mostly for Linux, but we should be consistent between platforms where possible). |
The PR was merged in. I have been fixing up Editor issues before pulling in the File dialog change as well. |
Thanks for fixing the Editor! |
The Editor is already pretty complex, so I'm not surprised there were issues with the upgrade. I also fixed some non-imGUI related issues I found as well (my own bugs) so it was a good idea to go through all of the UI anyway. |
Main motivation is
Settings pages and Editor (at least the parts of the editor that I'm smart enough to use :) ) all work fine.
This supersedes #418 and I'll add another PR if @luciusDXL is fine with this one.