Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added workaround for GLEW on wayland #386

Merged
merged 1 commit into from
Mar 1, 2024
Merged

Added workaround for GLEW on wayland #386

merged 1 commit into from
Mar 1, 2024

Conversation

Rosalie241
Copy link
Contributor

This patch adds a workaround to make GLEW initialize successfully on wayland, allowing the force engine to work properly when using wayland on linux, more information and existing workarounds can be found on the following issue:

nigels-com/glew#172

I'm not sure if this kind of workarounds are desired, so feel free to close this PR if you have no desire for such a thing!

luciusDXL
luciusDXL approved these changes Mar 1, 2024
View reviewed changes
Copy link
Owner

@luciusDXL luciusDXL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems ok, but be sure to remove when/if this workaround becomes unnecessary.

@luciusDXL luciusDXL merged commit 341db34 into luciusDXL:master Mar 1, 2024
1 check passed
@JakeSmarter
Copy link
Contributor

@fpiesche This may enable or require adding --socket=wayland and --socket=fallback-x11 in the flatpak build manifest.

@fpiesche
Copy link
Contributor

fpiesche commented Mar 1, 2024 •
edited
Loading

@fpiesche This may enable or require adding --socket=wayland and --socket=fallback-x11 in the flatpak build manifest.

As I understand from review feedback on other Flathub PRs I've made, these are only required for applications that are actually built for Wayland so we probably shouldn't need either, unless this comes with TFE being built against Wayland rather than X11. I'll give it a try locally though!

JakeSmarter added a commit to JakeSmarter/io.github.theforceengine.tfe that referenced this pull request Mar 8, 2024
@JakeSmarter
Drop local AppStream meta data in favor of upstream
7a94320 
Externalize launch script into a separate file
Enable Wayland support following luciusDXL/TheForceEngine#386
Move installing the launch script into a separate `module`
Use Flatpak Builder environment variables where applicable
Fix git tag pattern checker
Change `buildsystem` to `cmake`
Move editing the Desktop Entry file to `post-install` step
Add Flatpak extension support for mods
Externalize the default “AdjustableHud” mod into a separate but bundled Flatpak `.Mod` extension
JakeSmarter added a commit to JakeSmarter/io.github.theforceengine.tfe that referenced this pull request Mar 8, 2024
@JakeSmarter
Drop local AppStream meta data in favor of upstream
dfb52a9 
Externalize launch script into a separate file
Enable Wayland support following luciusDXL/TheForceEngine#386
Move installing the launch script into a separate `module`
Use Flatpak Builder environment variables where applicable
Fix git tag pattern checker
Change `buildsystem` to `cmake`
Move editing the Desktop Entry file to `post-install` step
Add Flatpak extension support for mods
Externalize the default “AdjustableHud” mod into a separate but bundled Flatpak `.Mod` extension
JakeSmarter added a commit to JakeSmarter/io.github.theforceengine.tfe that referenced this pull request Mar 11, 2024
@JakeSmarter
Drop local AppStream meta data in favor of upstream
ced7073 
Externalize launch script into a separate file
Enable Wayland support following luciusDXL/TheForceEngine#386
Move installing the launch script into a separate `module`
Use Flatpak Builder environment variables where applicable
Fix git tag pattern checker
Change `buildsystem` to `cmake`
Move editing the Desktop Entry file to `post-install` step
Add Flatpak extension support for mods
Externalize the default “AdjustableHud” mod into a separate but bundled Flatpak `.Mod` extension
JakeSmarter added a commit to JakeSmarter/io.github.theforceengine.tfe that referenced this pull request Mar 11, 2024
@JakeSmarter
Drop local AppStream meta data in favor of upstream
e68a995 
Externalize launch script into a separate file
Enable Wayland support following luciusDXL/TheForceEngine#386
Move installing the launch script into a separate `module`
Use Flatpak Builder environment variables where applicable
Fix git tag pattern checker
Change `buildsystem` to `cmake`
Move editing the Desktop Entry file to `post-install` step
Add Flatpak extension support for mods following luciusDXL/TheForceEngine#393
Externalize the default “AdjustableHud” mod into a separate but bundled Flatpak `.Mod` extension
@JakeSmarter JakeSmarter mentioned this pull request Mar 11, 2024
Open
JakeSmarter added a commit to JakeSmarter/io.github.theforceengine.tfe that referenced this pull request Mar 14, 2024
@JakeSmarter
Drop local AppStream meta data in favor of upstream
572c1a0 
Externalize launch script into a separate file
Enable Wayland support following luciusDXL/TheForceEngine#386
Move installing the launch script into a separate `module`
Use Flatpak Builder environment variables where applicable
Fix git tag pattern checker
Change `buildsystem` to `cmake`
Move editing the Desktop Entry file to `post-install` step
Add Flatpak extension support for mods following luciusDXL/TheForceEngine#393
Externalize the default “AdjustableHud” mod into a separate but bundled Flatpak `.Mod` extension
Add “Dark Forces Community Patch” mod
JakeSmarter added a commit to JakeSmarter/io.github.theforceengine.tfe that referenced this pull request Mar 14, 2024
@JakeSmarter
Drop local AppStream meta data in favor of upstream
8756b3f 
Externalize launch script into a separate file
Enable Wayland support following luciusDXL/TheForceEngine#386
Move installing the launch script into a separate `module`
Use Flatpak Builder environment variables where applicable
Fix git tag pattern checker
Change `buildsystem` to `cmake`
Move editing the Desktop Entry file to `post-install` step
Add Flatpak extension support for mods following luciusDXL/TheForceEngine#393
Externalize the default “AdjustableHud” mod into a separate but bundled Flatpak `.Mod` extension
JakeSmarter added a commit to JakeSmarter/io.github.theforceengine.tfe that referenced this pull request Mar 14, 2024
@JakeSmarter
Drop local AppStream meta data in favor of upstream
2328c77 
Externalize launch script into a separate file
Enable Wayland support following luciusDXL/TheForceEngine#386
Move installing the launch script into a separate `module`
Use Flatpak Builder environment variables where applicable
Fix git tag pattern checker
Change `buildsystem` to `cmake`
Move editing the Desktop Entry file to `post-install` step
Add Flatpak extension support for mods following luciusDXL/TheForceEngine#393
Externalize the default “AdjustableHud” mod into a separate but bundled Flatpak `.Mod` extension
JakeSmarter added a commit to JakeSmarter/io.github.theforceengine.tfe that referenced this pull request Apr 12, 2024
@JakeSmarter
Drop local AppStream meta data in favor of upstream
2013fec 
Externalize launch script into a separate file
Enable Wayland support following luciusDXL/TheForceEngine#386
Move installing the launch script into a separate `module`
Use Flatpak Builder environment variables where applicable
Fix git tag pattern checker
Change `buildsystem` to `cmake`
Move editing the Desktop Entry file to `post-install` step
Add Flatpak extension support for mods following luciusDXL/TheForceEngine#393
Externalize the default “AdjustableHud” mod into a separate but bundled Flatpak `.Mod` extension
JakeSmarter added a commit to JakeSmarter/io.github.theforceengine.tfe that referenced this pull request Apr 12, 2024
@JakeSmarter
Drop local AppStream meta data in favor of upstream
d76e6c5 
Externalize launch script into a separate file
Enable Wayland support following luciusDXL/TheForceEngine#386
Move installing the launch script into a separate `module`
Use Flatpak Builder environment variables where applicable
Fix git tag pattern checker
Change `buildsystem` to `cmake`
Move editing the Desktop Entry file to `post-install` step
Add Flatpak extension support for mods following luciusDXL/TheForceEngine#393
Externalize the default “AdjustableHud” mod into a separate but bundled Flatpak `.Mod` extension
@mlauss2 mlauss2 mentioned this pull request Jun 27, 2024
Closed
JakeSmarter added a commit to JakeSmarter/io.github.theforceengine.tfe that referenced this pull request Jan 9, 2025
@JakeSmarter
Drop local AppStream meta data in favor of upstream
65923f6 
Externalize launch script into a separate file
Enable Wayland support following luciusDXL/TheForceEngine#386
Move installing the launch script into a separate `module`
Use Flatpak Builder environment variables where applicable
Fix git tag pattern checker
Change `buildsystem` to `cmake`
Add Flatpak extension support for mods following luciusDXL/TheForceEngine#393
Externalize the default “AdjustableHud” mod into a separate but bundled Flatpak `.Mod` extension
JakeSmarter added a commit to JakeSmarter/io.github.theforceengine.tfe that referenced this pull request Jan 9, 2025
@JakeSmarter
Drop local AppStream meta data in favor of upstream
c0b0121 
Externalize launch script into a separate file
Enable Wayland support following luciusDXL/TheForceEngine#386
Move installing the launch script into a separate `module`
Use Flatpak Builder environment variables where applicable
Fix git tag pattern checker
Change `buildsystem` to `cmake`
Add Flatpak extension support for mods following luciusDXL/TheForceEngine#393
Externalize the default “AdjustableHud” mod into a separate but bundled Flatpak `.Mod` extension
JakeSmarter added a commit to JakeSmarter/io.github.theforceengine.tfe that referenced this pull request Jan 18, 2025
@JakeSmarter
Drop local AppStream meta data in favor of upstream
331e41c 
Externalize launch script into a separate file
Enable Wayland support following luciusDXL/TheForceEngine#386
Move installing the launch script into a separate `module`
Use Flatpak Builder environment variables where applicable
Fix git tag pattern checker
Change `buildsystem` to `cmake`
Add Flatpak extension support for mods following luciusDXL/TheForceEngine#393
Externalize the default “AdjustableHud” mod into a separate but bundled Flatpak `.Mod` extension
JakeSmarter added a commit to JakeSmarter/io.github.theforceengine.tfe that referenced this pull request Jan 19, 2025
@JakeSmarter
Drop local AppStream meta data in favor of upstream
2592efc 
Externalize launch script into a separate file
Enable Wayland support following luciusDXL/TheForceEngine#386
Move installing the launch script into a separate `module`
Use Flatpak Builder environment variables where applicable
Fix git tag pattern checker
Change `buildsystem` to `cmake`
Add Flatpak extension support for mods following luciusDXL/TheForceEngine#393
Externalize the default “AdjustableHud” mod into a separate but bundled Flatpak `.Mod` extension
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@luciusDXL luciusDXL luciusDXL approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Rosalie241 @JakeSmarter @fpiesche @luciusDXL