Enable separate building and packaging of TFE and the “AdjustableHud” mod #393
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JakeSmarter
force-pushed
the
AdjustableHud_mod
branch
2 times, most recently
from
526c9a1 to
b453ba5
Compare
JakeSmarter
added a commit
to JakeSmarter/io.github.theforceengine.tfe
that referenced
this pull request
Mar 11, 2024
Externalize launch script into a separate file Enable Wayland support following luciusDXL/TheForceEngine#386 Move installing the launch script into a separate `module` Use Flatpak Builder environment variables where applicable Fix git tag pattern checker Change `buildsystem` to `cmake` Move editing the Desktop Entry file to `post-install` step Add Flatpak extension support for mods following luciusDXL/TheForceEngine#393 Externalize the default “AdjustableHud” mod into a separate but bundled Flatpak `.Mod` extension
JakeSmarter
added a commit
to JakeSmarter/io.github.theforceengine.tfe
that referenced
this pull request
Mar 14, 2024
Externalize launch script into a separate file Enable Wayland support following luciusDXL/TheForceEngine#386 Move installing the launch script into a separate `module` Use Flatpak Builder environment variables where applicable Fix git tag pattern checker Change `buildsystem` to `cmake` Move editing the Desktop Entry file to `post-install` step Add Flatpak extension support for mods following luciusDXL/TheForceEngine#393 Externalize the default “AdjustableHud” mod into a separate but bundled Flatpak `.Mod` extension Add “Dark Forces Community Patch” mod
JakeSmarter
added a commit
to JakeSmarter/io.github.theforceengine.tfe
that referenced
this pull request
Mar 14, 2024
Externalize launch script into a separate file Enable Wayland support following luciusDXL/TheForceEngine#386 Move installing the launch script into a separate `module` Use Flatpak Builder environment variables where applicable Fix git tag pattern checker Change `buildsystem` to `cmake` Move editing the Desktop Entry file to `post-install` step Add Flatpak extension support for mods following luciusDXL/TheForceEngine#393 Externalize the default “AdjustableHud” mod into a separate but bundled Flatpak `.Mod` extension
JakeSmarter
added a commit
to JakeSmarter/io.github.theforceengine.tfe
that referenced
this pull request
Mar 14, 2024
Externalize launch script into a separate file Enable Wayland support following luciusDXL/TheForceEngine#386 Move installing the launch script into a separate `module` Use Flatpak Builder environment variables where applicable Fix git tag pattern checker Change `buildsystem` to `cmake` Move editing the Desktop Entry file to `post-install` step Add Flatpak extension support for mods following luciusDXL/TheForceEngine#393 Externalize the default “AdjustableHud” mod into a separate but bundled Flatpak `.Mod` extension
JakeSmarter
force-pushed
the
AdjustableHud_mod
branch
from
b453ba5 to
91dccdd
Compare
JakeSmarter
added a commit
to JakeSmarter/flathub
that referenced
this pull request
Mar 15, 2024
JakeSmarter
added a commit
to JakeSmarter/flathub
that referenced
this pull request
Mar 15, 2024
JakeSmarter
added a commit
to JakeSmarter/flathub
that referenced
this pull request
Mar 16, 2024
JakeSmarter
added a commit
to JakeSmarter/flathub
that referenced
this pull request
Mar 17, 2024
* Drop deprecated `type` attribute from `id` element * Add *globally* accessible `icon` * Fix typo in de `li` * Add `keywords` synced with Desktop Entry’s `Keywords` key
* `CMakeLists.txt`: Add `ENABLE_TFE` and `ENABLE_ADJUSTABLEHOD_MOD` configuration options for package maintainers to be able to build separate packages * Add AppStream component meta data for the built‑in “AdjustableHud” mod * `README.md`: Add info on packaging TFE and the “AdjustableHud” mod * `ProjectStructure.md`: Add `Mods` directory and description
JakeSmarter
force-pushed
the
AdjustableHud_mod
branch
from
91dccdd to
f78ecae
Compare
luciusDXL
approved these changes
Mar 24, 2024
JakeSmarter
added a commit
to JakeSmarter/flathub
that referenced
this pull request
Mar 29, 2024
JakeSmarter
added a commit
to JakeSmarter/flathub
that referenced
this pull request
Apr 2, 2024
JakeSmarter
added a commit
to JakeSmarter/flathub
that referenced
this pull request
Apr 3, 2024
JakeSmarter
added a commit
to JakeSmarter/io.github.theforceengine.tfe
that referenced
this pull request
Apr 12, 2024
Externalize launch script into a separate file Enable Wayland support following luciusDXL/TheForceEngine#386 Move installing the launch script into a separate `module` Use Flatpak Builder environment variables where applicable Fix git tag pattern checker Change `buildsystem` to `cmake` Move editing the Desktop Entry file to `post-install` step Add Flatpak extension support for mods following luciusDXL/TheForceEngine#393 Externalize the default “AdjustableHud” mod into a separate but bundled Flatpak `.Mod` extension
JakeSmarter
added a commit
to JakeSmarter/io.github.theforceengine.tfe
that referenced
this pull request
Apr 12, 2024
Externalize launch script into a separate file Enable Wayland support following luciusDXL/TheForceEngine#386 Move installing the launch script into a separate `module` Use Flatpak Builder environment variables where applicable Fix git tag pattern checker Change `buildsystem` to `cmake` Move editing the Desktop Entry file to `post-install` step Add Flatpak extension support for mods following luciusDXL/TheForceEngine#393 Externalize the default “AdjustableHud” mod into a separate but bundled Flatpak `.Mod` extension
JakeSmarter
added a commit
to JakeSmarter/io.github.theforceengine.tfe
that referenced
this pull request
Jan 9, 2025
Externalize launch script into a separate file Enable Wayland support following luciusDXL/TheForceEngine#386 Move installing the launch script into a separate `module` Use Flatpak Builder environment variables where applicable Fix git tag pattern checker Change `buildsystem` to `cmake` Add Flatpak extension support for mods following luciusDXL/TheForceEngine#393 Externalize the default “AdjustableHud” mod into a separate but bundled Flatpak `.Mod` extension
JakeSmarter
added a commit
to JakeSmarter/io.github.theforceengine.tfe
that referenced
this pull request
Jan 9, 2025
Externalize launch script into a separate file Enable Wayland support following luciusDXL/TheForceEngine#386 Move installing the launch script into a separate `module` Use Flatpak Builder environment variables where applicable Fix git tag pattern checker Change `buildsystem` to `cmake` Add Flatpak extension support for mods following luciusDXL/TheForceEngine#393 Externalize the default “AdjustableHud” mod into a separate but bundled Flatpak `.Mod` extension
JakeSmarter
added a commit
to JakeSmarter/io.github.theforceengine.tfe
that referenced
this pull request
Jan 18, 2025
Externalize launch script into a separate file Enable Wayland support following luciusDXL/TheForceEngine#386 Move installing the launch script into a separate `module` Use Flatpak Builder environment variables where applicable Fix git tag pattern checker Change `buildsystem` to `cmake` Add Flatpak extension support for mods following luciusDXL/TheForceEngine#393 Externalize the default “AdjustableHud” mod into a separate but bundled Flatpak `.Mod` extension
JakeSmarter
added a commit
to JakeSmarter/io.github.theforceengine.tfe
that referenced
this pull request
Jan 19, 2025
Externalize launch script into a separate file Enable Wayland support following luciusDXL/TheForceEngine#386 Move installing the launch script into a separate `module` Use Flatpak Builder environment variables where applicable Fix git tag pattern checker Change `buildsystem` to `cmake` Add Flatpak extension support for mods following luciusDXL/TheForceEngine#393 Externalize the default “AdjustableHud” mod into a separate but bundled Flatpak `.Mod` extension
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improves the life of package maintainers and paves the way for integrated mod distribution.
Conceptually, building the “AdjustableHud” mod should have been its own CMake target. But, since CMake is conceptually flawed in general and thus custom build target support in CMake is either incomplete or just a disgrace to implement, we have to go the ugly route of adding build configuration options. Yes, it is ugly but it works and is obviously so intended by CMake devs.