Rename with_defaults to tag_defaults #552
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR aims to close #548 This PR tackles: - Renaming with_defaults in `browser_app_skeleton/src/components/shared/field.cr` to the new `tag_defaults` signature implemented [here](luckyframework/lucky#1262) - Renaming the yielded block from `input_builder` to `tag_builder` to keep all Lucky-generated docs/code/comments consistent and (hopefully) better convey meaning
jwoertink
reviewed
Sep 17, 2020
There was a problem hiding this comment.
This will be fine. Obviously we will need to update the Lucky version. To get the specs to pass, we can now update https://github.com/luckyframework/lucky_cli/blob/master/shard.override.yml to point to lucky master. Once the other PR is merged in, we can rerun specs here and they will be good.
|
@jwoertink Sorry, somehow I missed your comment. Do you want me to go ahead and update shard.override.yml in this PR? |
|
@stephendolan yeah, it's a pretty common thing we end up having to do so it's fine. Update it to point to lucky master, and we will see if the specs all pass. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to close #548
It will need to be released in conjunction with luckyframework/lucky#1262
This PR tackles:
browser_app_skeleton/src/components/shared/field.crto the newtag_defaultssignature implemented hereinput_buildertotag_builderto keep all Lucky-generated docs/code/comments consistent and (hopefully) better convey meaningI wasn't sure how to get the specs passing here since the method won't be found in Lucky until a new version is available.