lucky dev: When Ctrl+C is pressed, wait for the child process to handle the signal and finish - rather than us immediately exiting and leaving it to log shutting down messages from the background #572
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #570. I've just used the approach I suggested there.
I wasn't sure how/if to write a spec for this, so I haven't. Is that acceptable?
To test it manually, I ran this from my app directory before and after the change to verify the behaviour with Foreman:
$ crystal run ~/Projects/lucky_cli/src/lucky.cr -- dev
Before:
After:
The slow already-failing integration specs were an unfortunately painful distraction =P
The first:
Finding #552, I learned I needed to be using lucky master. But was then confused why
shard.override.yml
didn't seem to be working to select it. I finally realised I had to use enable that by running the spec like:(. ./script/override_shards && crystal spec spec/integration/init_web_spec.cr:10)
Running that then resulted in:
From which I found luckyframework/avram#469. I briefly considered updating
RequestPasswordReset
to this new interface, but couldn't easily see how to do so. At that point I backed away slowly, haha. I'll leave you folks to work out the inter-repo dependency in rolling out that change.