Add GameHandler class #14

AleksandraCyp · 2021-02-06T13:37:00Z

No description provided.

lukaszdutka · 2021-02-06T17:09:26Z

src/gameHandlerClass.ts

+    if (!allHPs.includes(0)) {
+      return false;
+    } else {
+      return true;
+    }


this logic says that if there exists at least ONE pokemon that has 0 hp - then the game is over - it should be different. If all three pokemons of one of players have 0 hp - then the game should be finished.

(includes method checks if there exists at least one such element)

also - you shouldn't access private property "_currentHP" :) you should use "isAlive()" method

Also you can use ready getter from player class this._playerOne.alivePokemons and check if the list is empty

lukaszdutka · 2021-02-06T17:15:09Z

src/gameHandlerClass.ts

+    const getallHPs = (player: Player): number[] =>
+      player.pokemons.map((pokemon) => pokemon._currentHP);
+    const firstPlayerPokemonsHP: number[] = getallHPs(this._playerOne);
+    if (firstPlayerPokemonsHP.includes(0)) {


"includes" refers to "one element"
[0, 50, 50].includes(0) - returns true, but should return false
[0,0,0].something() - should return true only in this case

lukaszdutka · 2021-02-06T17:15:34Z

src/gameHandlerClass.ts

+    if (!this.isGameFinished())
+      return new Error("You cannot get the winner. The game is not over.");
+    const getallHPs = (player: Player): number[] =>
+      player.pokemons.map((pokemon) => pokemon._currentHP);


same as previously - use isAlive() instead of _currentHP

lukaszdutka · 2021-02-06T17:16:28Z

src/gameHandlerClass.ts

+    if (this._currentPlayer === this._playerOne) return this._playerTwo;
+    return this._playerOne;


You can flex your programming skills and astonish your peers by using ternary operator:

Suggested change

if (this._currentPlayer === this._playerOne) return this._playerTwo;

return this._playerOne;

return this._currentPlayer === this._playerOne ? this._playerTwo : this._playerOne;

lukaszdutka · 2021-02-06T17:17:10Z

src/gameHandlerClass.ts

+import { Pokemon } from "./pokemonClass";
+
+export class GameHandler {
+  constructor(private _playerOne: Player, private _playerTwo: Player) {}


nice shorthand! Didn't know about it :)

lukaszdutka

Need some changes, there are bugs in this code. But some clever things also exists there :)

lukaszdutka · 2021-02-07T18:34:21Z

src/__tests__/gameHandlerClass.spec.ts

+
+  it("GameHandler.isGameFinished should return false if every player has at least one pokemon", () => {
+    // Given
+    const factory_0 = new PokemonFactory(pokeData);


what's with this naming convention?

each test is separated from others, so there is no need for this suffix _0, _1 etc.

lukaszdutka · 2021-02-07T18:35:43Z

src/__tests__/gameHandlerClass.spec.ts

+    const isGameFinished_0 = new GameHandler(
+      playerOne_0,
+      playerTwo_0
+    ).isGameFinished();


GameHandler is part of given, in when there should be only isGameFinished()

lukaszdutka · 2021-02-07T18:36:23Z

src/__tests__/gameHandlerClass.spec.ts

+    playerOne_1.pokemons.forEach((pokemon) =>
+      pokemon.subtractHP(pokemon.maxHP)
+    );


it looks more like when but it's discussable.

lukaszdutka · 2021-02-07T18:37:18Z

src/gameHandlerClass.ts

+  }
+
+  private didPlayerLoose(player: Player): boolean {
+    return player.alivePokemons.length < 1;


why not simply .length == 0? 😕

lukaszdutka · 2021-02-07T18:39:36Z

src/__tests__/gameHandlerClass.spec.ts

+    const playerOne_2 = new Player("Wojtek", [
+      factory_2.getPokemonByName("bulbasaur"),
+      factory_2.getPokemonByName("charmander"),
+      factory_2.getPokemonByName("pikachu"),
+    ]);
+    const playerTwo_2 = new Player("Ania", [
+      factory_2.getPokemonByName("squirtle"),
+      factory_2.getPokemonByName("weedle"),
+      factory_2.getPokemonByName("pidgey"),
+    ]);


you can also create helper methods at the end of the file, like:

const getPlayerOne = () => { return new Player("Wojtek", [ factory_2.getPokemonByName("bulbasaur"), factory_2.getPokemonByName("charmander"), factory_2.getPokemonByName("pikachu"), ]) }

and in test use only:

const playerOne = getPlayerOne();

the reasoning is that:
"You don't need to know exact details. You just need to know there are some players with some pokemons"

then, in the when section you can modify it a bit (like zero all the pokemon healths)

lukaszdutka

Nice work, cool tests! However, there are some readability changes that could be made :)

lukaszdutka · 2021-02-08T06:22:42Z

src/__tests__/gameHandlerClass.spec.ts

+  const getPlayerOne = (factory: PokemonFactory) => {
+    return new Player("Wojtek", [
+      factory.getPokemonByName("bulbasaur"),
+      factory.getPokemonByName("charmander"),
+      factory.getPokemonByName("pikachu"),
+    ]);
+  } 
+
+  const getPlayerTwo = (factory: PokemonFactory) => {
+    return new Player("Wojtek", [
+      factory.getPokemonByName("bulbasaur"),
+      factory.getPokemonByName("charmander"),
+      factory.getPokemonByName("pikachu"),
+    ]);
+  }


if both players are the same - why bother to have two identical functions? :P

lukaszdutka · 2021-02-08T06:24:11Z

src/__tests__/gameHandlerClass.spec.ts

+
+  it("GameHandler.isGameFinished should return false if every player has at least one pokemon", () => {
+    // Given
+    const factory = new PokemonFactory(pokeData);


I think that factory can be global, like getPlayerOne function.
Because using factory should be pure, factory.getPokemonByName should be (and is) pure function - it always returns the same (the same pokemon with same stats) for the same input (pokemon name)

lukaszdutka · 2021-02-08T06:25:12Z

src/__tests__/gameHandlerClass.spec.ts

+    playerOne.pokemons.forEach((pokemon) =>
+    pokemon.subtractHP(pokemon.maxHP));


can be in one line, but whatever :P

lukaszdutka · 2021-02-08T06:25:56Z

src/__tests__/gameHandlerClass.spec.ts

+    expect(winner).toThrowError(
+      "You cannot get the winner. The game is not over."
+    );


it also can be in one line

lukaszdutka · 2021-02-08T06:26:00Z

src/__tests__/gameHandlerClass.spec.ts

+    const winner = () =>
+      gameHandler.getWinner();


it also can be in one line

lukaszdutka · 2021-02-08T06:26:09Z

src/__tests__/gameHandlerClass.spec.ts

+    playerTwo.pokemons.forEach((pokemon) =>
+    pokemon.subtractHP(pokemon.maxHP));


it also can be in one line

lukaszdutka

🏆

* Function RenderChoosePokemonScreen * MNG-102 fight method implemented * MNG-102 Add tests for fight class. Fix pokemon subtract HP * Appendig function to the whole index.ts * MNG-88_StartButtonActivation (#12) * Add keyup to input * Add activateStart.ts * Uncomment html * Add class to activate/disable start button * Add activateStartButton function * Change class name to button-enabled * Corrections * MNG-89 clicking start should render choose pokemon screen (#17) * Function RenderChoosePokemonScreen * Appendig function to the whole index.ts * Corrections * MNG-95 Add GameHandler class (#14) * Add GameHandler class * Fix GameHandler class and add tests * Fix tests * MNG-107 Add geodude instead of tentacruel Filter moves to 4 for each pokemon Use mostly pokemon type moves * MNG-103 choose pokemon system (#19) * Add choosePokemonsPage.ts * Add all functions for choose pokemon page * Change event.target, loading time * MNG-94 MNG-108 Start a new game, add functions that will render the correct view (#20) * MNG-99 & MNG-100 > created menu and back button with options. Options need to be fixed (now are default). Animation also needs to look better * MNG-109 added * Blocking the start with unwritten name * added magicFunction * added animations for buttons * Style button * Blocking button when the name is too long * MNG-98 Add useMango to gameHandler class (#22) * Add useMango to gameHandler class * corrections type of mango value * Corrections * useMango i PlayerClass Co-authored-by: AleksandraCyp <73715885+AleksandraCyp@users.noreply.github.com> * MNG-97 MNG-101 change player&change pokemon (#24) * Add switch pokemon and switch Player game handler methods * Implement mango, change the structure (build up magic function) * remove an unnecessary comment * Update test parametrization and do not use json data * MNG-102 fight method implemented * MNG-102 Add tests for fight class. Fix pokemon subtract HP * Update test parametrization and do not use json data * Apply max shortcut Co-authored-by: AgataLudwiczynska <74932979+AgataLudwiczynska@users.noreply.github.com> Co-authored-by: mariusz-sm <74978639+mariusz-sm@users.noreply.github.com> Co-authored-by: AleksandraCyp <73715885+AleksandraCyp@users.noreply.github.com> Co-authored-by: Gosia Dziewit <gosia.dziewit@gmail.com>

Add GameHandler class

0aa2d9c

lukaszdutka reviewed Feb 6, 2021

View reviewed changes

lukaszdutka requested changes Feb 6, 2021

View reviewed changes

AleksandraCyp added 2 commits February 7, 2021 16:50

Merge branch 'master' into MNG-95-createGameHandler

3a76c3e

Fix GameHandler class and add tests

e6fec66

lukaszdutka reviewed Feb 7, 2021

View reviewed changes

lukaszdutka requested changes Feb 7, 2021

View reviewed changes

AleksandraCyp added 2 commits February 7, 2021 22:38

Merge branch 'master' into MNG-95-createGameHandler

ca6b13c

Fix tests

45ba47a

lukaszdutka reviewed Feb 8, 2021

View reviewed changes

lukaszdutka approved these changes Feb 8, 2021

View reviewed changes

lukaszdutka merged commit 3a67f72 into master Feb 8, 2021

lukaszdutka deleted the MNG-95-createGameHandler branch February 8, 2021 07:11

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add GameHandler class #14

Add GameHandler class #14

AleksandraCyp commented Feb 6, 2021

lukaszdutka Feb 6, 2021

lukaszdutka Feb 6, 2021

daria305 Feb 7, 2021

lukaszdutka Feb 6, 2021

lukaszdutka Feb 6, 2021

lukaszdutka Feb 6, 2021

lukaszdutka Feb 6, 2021

lukaszdutka left a comment

lukaszdutka Feb 7, 2021

lukaszdutka Feb 7, 2021

lukaszdutka Feb 7, 2021

lukaszdutka Feb 7, 2021

lukaszdutka Feb 7, 2021

lukaszdutka Feb 7, 2021

lukaszdutka left a comment

lukaszdutka Feb 8, 2021

lukaszdutka Feb 8, 2021 •

edited

Loading

lukaszdutka Feb 8, 2021

lukaszdutka Feb 8, 2021

lukaszdutka Feb 8, 2021

lukaszdutka Feb 8, 2021

lukaszdutka left a comment

		if (this._currentPlayer === this._playerOne) return this._playerTwo;
		return this._playerOne;

	if (this._currentPlayer === this._playerOne) return this._playerTwo;
	return this._playerOne;
	return this._currentPlayer === this._playerOne ? this._playerTwo : this._playerOne;

		playerOne.pokemons.forEach((pokemon) =>
		pokemon.subtractHP(pokemon.maxHP));

		playerTwo.pokemons.forEach((pokemon) =>
		pokemon.subtractHP(pokemon.maxHP));

Add GameHandler class #14

Add GameHandler class #14

Conversation

AleksandraCyp commented Feb 6, 2021

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

lukaszdutka left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

lukaszdutka left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

lukaszdutka Feb 8, 2021 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

lukaszdutka left a comment

Choose a reason for hiding this comment

lukaszdutka Feb 8, 2021 •

edited

Loading