MNG - 98 Add useMango to gameHandler class #22

AgataLudwiczynska · 2021-02-10T17:34:57Z

No description provided.

lukaszdutka · 2021-02-10T17:39:04Z

src/playerClass.ts

@@ -4,6 +4,7 @@ export class Player {
  private _name: string;
  private _pokemons: Pokemon[];
  private _indexOfActivePokemon: number;
+  private _mango: Number;


There is only one mango per player, so it can be boolean called _hasMango

lukaszdutka

Looks good, but need some polishing :)

lukaszdutka · 2021-02-10T17:39:09Z

src/playerClass.ts

@@ -14,6 +15,7 @@ export class Player {
    this._name = name;
    this._pokemons = pokemons;
    this._indexOfActivePokemon = 0;
+    this._mango=1;


lukaszdutka · 2021-02-10T17:39:14Z

src/playerClass.ts

@@ -37,6 +39,14 @@ export class Player {
    return alivePokemonsTab;
  }

+  reduceNumberMango(): void {
+    this._mango = <any>this._mango - 1;


lukaszdutka · 2021-02-10T17:39:54Z

src/gameHandlerClass.ts

@@ -35,4 +35,11 @@ export class GameHandler {
      ? this._playerTwo
      : this._playerOne;
  }
-}
+
+  useMango(): void | Error{


ideally there should be one more method: "can I use mango" or something like that, that would be used to render if "use mango" button will be disabled or enabled :)

lukaszdutka · 2021-02-10T20:06:03Z

src/gameHandlerClass.ts

@@ -35,4 +35,15 @@ export class GameHandler {
      ? this._playerTwo
      : this._playerOne;
  }
+
+  canIUseMango(): Boolean {


canUseMango is enough :)

well, this whole method is probably not necessary :P
But it might be, if it would be used somewhere outside of gamehandler 🤔

I think it will actually be needed to disable button "use Mango"

lukaszdutka · 2021-02-10T20:08:21Z

src/gameHandlerClass.ts

+  }
+
+  useMango(): void | Error {
+    if (this.canIUseMango() == false)


this.canIUseMango() == false it's the same as:
!this.currentPlayer.hasMango

lukaszdutka · 2021-02-10T20:47:38Z

src/playerClass.ts

@@ -37,6 +39,14 @@ export class Player {
    return alivePokemonsTab;
  }

+  reduceNumberMango(): void {


please rename this method :P and add validation inside:
if you ate mango once, then calling this method again should throw an error

AleksandraCyp · 2021-02-11T15:05:51Z

src/gameHandlerClass.ts

@@ -35,4 +35,15 @@ export class GameHandler {
      ? this._playerTwo
      : this._playerOne;
  }
+
+  canUseMango(): Boolean {


Why did you add this to game handler? Wee need it only in our player class (we shouldn't put it here because it's a poperty and a method of a player, one player may have a mango, but the second one not necessarily). The whole logic about using mango and healing should be put in the useMango function in playerClass

AleksandraCyp · 2021-02-11T15:08:05Z

src/playerClass.ts

@@ -37,6 +39,16 @@ export class Player {
    return alivePokemonsTab;
  }

+  useMango(): void | Error {


add the whole logic about using mango here, in player class

* Function RenderChoosePokemonScreen * MNG-102 fight method implemented * MNG-102 Add tests for fight class. Fix pokemon subtract HP * Appendig function to the whole index.ts * MNG-88_StartButtonActivation (#12) * Add keyup to input * Add activateStart.ts * Uncomment html * Add class to activate/disable start button * Add activateStartButton function * Change class name to button-enabled * Corrections * MNG-89 clicking start should render choose pokemon screen (#17) * Function RenderChoosePokemonScreen * Appendig function to the whole index.ts * Corrections * MNG-95 Add GameHandler class (#14) * Add GameHandler class * Fix GameHandler class and add tests * Fix tests * MNG-107 Add geodude instead of tentacruel Filter moves to 4 for each pokemon Use mostly pokemon type moves * MNG-103 choose pokemon system (#19) * Add choosePokemonsPage.ts * Add all functions for choose pokemon page * Change event.target, loading time * MNG-94 MNG-108 Start a new game, add functions that will render the correct view (#20) * MNG-99 & MNG-100 > created menu and back button with options. Options need to be fixed (now are default). Animation also needs to look better * MNG-109 added * Blocking the start with unwritten name * added magicFunction * added animations for buttons * Style button * Blocking button when the name is too long * MNG-98 Add useMango to gameHandler class (#22) * Add useMango to gameHandler class * corrections type of mango value * Corrections * useMango i PlayerClass Co-authored-by: AleksandraCyp <73715885+AleksandraCyp@users.noreply.github.com> * MNG-97 MNG-101 change player&change pokemon (#24) * Add switch pokemon and switch Player game handler methods * Implement mango, change the structure (build up magic function) * remove an unnecessary comment * Update test parametrization and do not use json data * MNG-102 fight method implemented * MNG-102 Add tests for fight class. Fix pokemon subtract HP * Update test parametrization and do not use json data * Apply max shortcut Co-authored-by: AgataLudwiczynska <74932979+AgataLudwiczynska@users.noreply.github.com> Co-authored-by: mariusz-sm <74978639+mariusz-sm@users.noreply.github.com> Co-authored-by: AleksandraCyp <73715885+AleksandraCyp@users.noreply.github.com> Co-authored-by: Gosia Dziewit <gosia.dziewit@gmail.com>

Add useMango to gameHandler class

9f1aad4

lukaszdutka reviewed Feb 10, 2021

View reviewed changes

lukaszdutka requested changes Feb 10, 2021

View reviewed changes

corrections type of mango value

bfeabfd

lukaszdutka reviewed Feb 10, 2021

View reviewed changes

Corrections

808dd98

AleksandraCyp requested changes Feb 11, 2021

View reviewed changes

useMango i PlayerClass

5812c16

AleksandraCyp approved these changes Feb 11, 2021

View reviewed changes

Merge branch 'master' into MNG-98-useMango-option-in-gameHandler-class

a44865e

lukaszdutka merged commit 15911f8 into master Feb 11, 2021

lukaszdutka deleted the MNG-98-useMango-option-in-gameHandler-class branch February 11, 2021 16:28

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

MNG - 98 Add useMango to gameHandler class #22

MNG - 98 Add useMango to gameHandler class #22

AgataLudwiczynska commented Feb 10, 2021

lukaszdutka Feb 10, 2021

lukaszdutka left a comment

lukaszdutka Feb 10, 2021

lukaszdutka Feb 10, 2021

lukaszdutka Feb 10, 2021

lukaszdutka Feb 10, 2021

lukaszdutka Feb 10, 2021

AgataLudwiczynska Feb 10, 2021

lukaszdutka Feb 10, 2021 •

edited

Loading

lukaszdutka Feb 10, 2021 •

edited

Loading

lukaszdutka Feb 10, 2021

AleksandraCyp Feb 11, 2021

AleksandraCyp Feb 11, 2021

MNG - 98 Add useMango to gameHandler class #22

MNG - 98 Add useMango to gameHandler class #22

Conversation

AgataLudwiczynska commented Feb 10, 2021

Choose a reason for hiding this comment

lukaszdutka left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

lukaszdutka Feb 10, 2021 • edited Loading

Choose a reason for hiding this comment

lukaszdutka Feb 10, 2021 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

lukaszdutka Feb 10, 2021 •

edited

Loading

lukaszdutka Feb 10, 2021 •

edited

Loading