Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Porting depthai_ros v2.7.1 to Foxy #224

Merged
merged 47 commits into from
Apr 25, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
47 commits
Select commit Hold shift + click to select a range
91b8cac
separate branch for humble
Serafadam Nov 9, 2022
ca4d011
remove gcc10 from dockerfile
Serafadam Nov 15, 2022
334ae75
Revert "remove gcc10 from dockerfile"
Serafadam Nov 15, 2022
8e195af
Humble dockerfile (#166)
Serafadam Nov 22, 2022
087c13b
minor arg change
Serafadam Nov 22, 2022
a331206
Monolithic node (#176)
Serafadam Dec 16, 2022
aa2825c
Depth param update (#183)
Serafadam Dec 19, 2022
d8e4724
add rviz config files (#184)
Serafadam Dec 21, 2022
165bbc9
Camera start bugfix (#185)
Serafadam Dec 21, 2022
8892bfc
remove id mapping (#194)
Serafadam Jan 10, 2023
7f9f735
update version and changelog (#196)
Serafadam Jan 11, 2023
e4555b9
Low bandwidth backport (#197)
Serafadam Jan 12, 2023
650fe87
fix typo (#204)
Serafadam Jan 17, 2023
0588cb3
Pipeline generator - humble (#203)
Serafadam Jan 18, 2023
6f3794b
Workflow update (#206)
Serafadam Jan 18, 2023
7ea744f
Fix tag push humble (#208)
Serafadam Jan 19, 2023
0fa72b6
Bugfix ros timestamp humble (#218)
Serafadam Feb 6, 2023
852ed51
add monolithic node to foxy
Serafadam Feb 9, 2023
4b77e23
Calibration - Humble (#227)
Serafadam Feb 15, 2023
fabd2d3
Usb port humble (#229)
Serafadam Feb 16, 2023
01dcdd5
Merge branch 'humble' of https://github.com/luxonis/depthai-ros into …
Serafadam Feb 16, 2023
5e1d3b0
minor fix
Serafadam Feb 16, 2023
a55cf7f
Minor bugfixes - Humble (#241)
Serafadam Feb 24, 2023
49152be
update changelog version
Serafadam Feb 27, 2023
29cf4a0
Build time improvements for Humble (#246)
Serafadam Mar 17, 2023
822f5a0
Fixed nnName bugs. (#253)
RangerOnMars Mar 22, 2023
ccdd4f9
Adding depthai_filters package in Humble (#247)
Serafadam Mar 24, 2023
5221d30
Depthai descriptions humble (#256)
Serafadam Mar 27, 2023
f25effe
XLinkIn - Humble (#261)
Serafadam Mar 27, 2023
92f0a53
Merge branch 'humble' of https://github.com/luxonis/depthai-ros into …
Serafadam Mar 27, 2023
5ab5fdc
update filters for foxy
Serafadam Mar 27, 2023
ff418f4
remove hypothesis from msg
Serafadam Mar 27, 2023
d14b5d7
updates for foxy
Serafadam Mar 28, 2023
1207fa2
filters fix
Serafadam Mar 28, 2023
2455f05
Merge branch 'filters_fix' of https://github.com/luxonis/depthai-ros …
Serafadam Mar 28, 2023
3ef5e64
formatting
Serafadam Mar 28, 2023
ae5aa58
filters fix (#264)
Serafadam Mar 28, 2023
2d96736
Version bump to 2.7.0 (#265)
Serafadam Mar 28, 2023
7059749
Fix rgbd_pcl configuration (#269)
borongyuan Apr 4, 2023
571c354
Custom output size (#267)
Serafadam Apr 4, 2023
7c8d9fd
fix resolution width/height, add THE_1440X1080 for IMX296 (#277)
borongyuan Apr 6, 2023
786288e
Update changelog 2.7.1 (#274)
Serafadam Apr 6, 2023
1cd447a
add DisparityWidth, Disparity Companding, SubpixelFractionalBits opti…
borongyuan Apr 20, 2023
c292264
inertial node ir fix (#289)
Serafadam Apr 21, 2023
157f9c9
Merge branch 'humble' of https://github.com/luxonis/depthai-ros into …
Serafadam Apr 24, 2023
45c144c
changecmake version
Serafadam Apr 25, 2023
590f074
format
Serafadam Apr 25, 2023
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
46 changes: 46 additions & 0 deletions .devcontainer/devcontainer.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,46 @@
// See https://aka.ms/vscode-remote/devcontainer.json for format details.
{
"dockerFile": "../src/depthai-ros/Dockerfile",
"build": {
"args": {"BUILD_SEQUENTIAL": "1",
"USE_RVIZ": "1"}
},
"remoteUser": "root",
"runArgs": [
"--device=/dev/ttyUSB0",
"--privileged",
"--network=host",
"--cap-add=SYS_PTRACE",
"--security-opt=seccomp:unconfined",
"--security-opt=apparmor:unconfined",
"--volume=/dev:/dev",
"--volume=/tmp/.X11-unix:/tmp/.X11-unix"
],
"containerEnv": { "DISPLAY": "${localEnv:DISPLAY}" },
// Set *default* container specific settings.json values on container create.
"settings": {
"terminal.integrated.profiles.linux": {
"zsh": {
"path": "zsh"
},
"bash": {
"path": "bash"
}

},
"terminal.integrated.defaultProfile.linux": "zsh"
},
"extensions": [
"dotjoshjohnson.xml",
"ms-azuretools.vscode-docker",
"ms-iot.vscode-ros",
"ms-python.python",
"ms-vscode.cpptools",
"redhat.vscode-yaml",
"smilerobotics.urdf",
"streetsidesoftware.code-spell-checker",
"twxs.cmake",
"yzhang.markdown-all-in-one",
"augustocdias.tasks-shell-input"
]
}
11 changes: 11 additions & 0 deletions .github/ISSUE_TEMPLATE/bug_report.md
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,11 @@ A clear and concise description of what the bug is.
**Minimal Reproducible Example**
Append the MRE to the bug report, [instructions here](https://docs.luxonis.com/en/latest/pages/support/#creating-minimal-reproducible-example)

If available launch files don't work in your case, please check if you also get errors while running:
- `stereo_inertial_node` in `depthai_examples`
- `camera` in `depthai_ros_driver`
- In case both fail to run, please check if you can run [the default python demo app](https://docs.luxonis.com/en/latest/#demo-script)

**Expected behavior**
A clear and concise description of what you expected to happen.

Expand All @@ -28,10 +33,16 @@ If applicable, add screenshots to help explain your problem.

Please also provide a screenshot of your pipeline using the [DepthAI Pipeline Graph](https://github.com/geaxgx/depthai_pipeline_graph).

You can save it in `depthai_ros_driver`, either by calling `/save_pipeline` ROS service, or by setting parameter `camera.i_pipeline_dump` in ROS 2 or `camera_i_pipeline_dump` in ROS. Pipeline dump is saved to `/tmp/pipeline.json`.

**Attach system log**
- Provide output of [log_system_information.py](https://github.com/luxonis/depthai/blob/main/log_system_information.py)
- Which OS/OS version are you using?
- Which ROS version are you using?
- Is `depthai-ros` built from source or installed from apt?
- Is `depthai/depthai-core` library installed from rosdep or manually? For rosdep install, check if `ros-<rosdistro>-depthai` package is installed, manual install can be checked with `ldconfig -p | grep depthai`
- Please include versions of following packages - `apt show ros-$ROS_DISTRO-depthai ros-$ROS_DISTRO-depthai-ros ros-$ROS_DISTRO-depthai-bridge ros-$ROS_DISTRO-depthai-ros-msgs ros-$ROS_DISTRO-depthai-ros-driver`
- To get additional logs, set `DEPTHAI_DEBUG=1` and paste the logs, either from command line or from latest log in `~/.ros/log`

**Additional context**
Add any other context about the problem here.
10 changes: 5 additions & 5 deletions .github/workflows/main.workflow.yml
Original file line number Diff line number Diff line change
Expand Up @@ -27,8 +27,8 @@ jobs:
strategy:
fail-fast: false
steps:
- uses: actions/checkout@v2.3.4
- uses: ros-tooling/setup-ros@0.4.1
- uses: actions/checkout@v3.3.0
- uses: ros-tooling/setup-ros@0.5.0
with:
required-ros-distributions: ${{ env.ROS_DISTRO }}
- uses: ros-tooling/action-ros2-lint@0.1.3
Expand All @@ -49,8 +49,8 @@ jobs:
matrix:
linter: [xmllint, pep257, lint_cmake]
steps:
- uses: actions/checkout@v2.3.4
- uses: ros-tooling/setup-ros@0.4.1
- uses: actions/checkout@v3.3.0
- uses: ros-tooling/setup-ros@0.5.0
with:
required-ros-distributions: ${{ env.ROS_DISTRO }}
- uses: ros-tooling/action-ros2-lint@0.1.3
Expand Down Expand Up @@ -116,5 +116,5 @@ jobs:
push: ${{ env.PUSH }}
no-cache: true
tags: |
luxonis/depthai-ros:${{ env.ROS_DISTRO }}-${{ steps.vars.outputs.short_ref }}
luxonis/depthai-ros:${{ steps.vars.outputs.short_ref }}
luxonis/depthai-ros:${{ env.ROS_DISTRO }}-latest
1 change: 0 additions & 1 deletion .gitignore
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
*.json
.vscode
devel
__pycache__
Expand Down
12 changes: 7 additions & 5 deletions Dockerfile
Original file line number Diff line number Diff line change
@@ -1,23 +1,25 @@
ARG ROS_DISTRO=humble
ARG ROS_DISTRO=foxy
FROM ros:${ROS_DISTRO}-ros-base
ARG USE_RVIZ
ARG BUILD_SEQUENTIAL=0
ENV DEBIAN_FRONTEND=noninteractive
RUN apt-get update \
&& apt-get -y install --no-install-recommends software-properties-common git libusb-1.0-0-dev wget zsh python3-colcon-common-extensions


ENV DEBIAN_FRONTEND=dialog
RUN sh -c "$(wget https://raw.github.com/ohmyzsh/ohmyzsh/master/tools/install.sh -O -)"

ENV WS=/ws
RUN mkdir -p $WS/src
COPY ./ .$WS/src/depthai_ros
RUN cd .$WS/ && rosdep install --from-paths src --ignore-src -y
RUN if [ "$BUILD_SEQUENTIAL" = "1" ] ; then cd .$WS/ && . /opt/ros/${ROS_DISTRO}/setup.sh && colcon build --executor sequential --cmake-args -DCMAKE_BUILD_TYPE=Release ; else cd .$WS/ && . /opt/ros/${ROS_DISTRO}/setup.sh && colcon build --cmake-args -DCMAKE_BUILD_TYPE=Release; fi
COPY ./ .$WS/src/depthai-ros
RUN cd .$WS/ && rosdep install --from-paths src --ignore-src -y

RUN cd .$WS/ && . /opt/ros/${ROS_DISTRO}/setup.sh && ./src/depthai-ros/build.sh -s $BUILD_SEQUENTIAL -r 1 -m 1
RUN if [ "$USE_RVIZ" = "1" ] ; then echo "RVIZ ENABLED" && sudo apt install -y ros-${ROS_DISTRO}-rviz2 ros-${ROS_DISTRO}-rviz-imu-plugin ; else echo "RVIZ NOT ENABLED"; fi
RUN echo "if [ -f ${WS}/install/setup.zsh ]; then source ${WS}/install/setup.zsh; fi" >> $HOME/.zshrc
RUN echo 'eval "$(register-python-argcomplete3 ros2)"' >> $HOME/.zshrc
RUN echo 'eval "$(register-python-argcomplete3 colcon)"' >> $HOME/.zshrc
RUN echo "if [ -f ${WS}/install/setup.bash ]; then source ${WS}/install/setup.bash; fi" >> $HOME/.bashrc
ENTRYPOINT [ "/ws/src/depthai_ros/entrypoint.sh" ]
ENTRYPOINT [ "/ws/src/depthai-ros/entrypoint.sh" ]
CMD ["zsh"]
Loading