Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crash, Preferences related? #217

Closed
gingerr opened this issue Apr 8, 2020 · 6 comments
Closed

Crash, Preferences related? #217

gingerr opened this issue Apr 8, 2020 · 6 comments

Comments

@gingerr
Copy link
Contributor

gingerr commented Apr 8, 2020

Hi @lwouis,

ive just updated to the latest version. Some of the dropdown options were empty in the Preferences panel. Ive set them and then the application crashed when i summoned AltTab and later it crashed already when i opened the Preferences panel.

Ive deleted the defaults defaults delete com.lwouis.alt-tab-macos and restarted the application and was able to use the application with its default settings.

image

But in the preferences panel all dropdowns were empty (nothing is selected) and when i changed any of them the application crashed when i summoned AltTab.

When i select something for all of the available dropdowns the application crashes already when opening the Preferences panel.

Can you observe the same behavior?

Mariusz

@lwouis
Copy link
Owner

lwouis commented Apr 8, 2020

It looks like it's localization-related. Let me try to reproduce this issue

@lwouis
Copy link
Owner

lwouis commented Apr 8, 2020

I can reproduce it when the app is in non-English language. The problem is that the dropdown preferences are stored in the local language, meaning when it's time to check what's selected, it fails to find the key, which coincides with the English value.

I'm surprised that this issue is surfacing now, since we had the same logic for the "Show on display:" dropdown for quite a while now. I guess it shows that very few users use this.

I'll work on a fix as soon as possible!

@lwouis lwouis closed this as completed in 5447d5f Apr 8, 2020
lwouis pushed a commit that referenced this issue Apr 8, 2020
## [3.6.2](v3.6.1...v3.6.2) (2020-04-08)

### Bug Fixes

* avoid text flickering on main ui (closes [#197](#197)) ([4eb9db0](4eb9db0))
* dropdown preferences crashed in non-english (closes [#217](#217)) ([5447d5f](5447d5f))
@lwouis
Copy link
Owner

lwouis commented Apr 8, 2020

I release an update with a fix. @gingerr and @buttercrab, you could please tell me if it's fixed?

Please run defaults delete com.lwouis.alt-tab-macos beforehand, to remove old preferences. I will open a ticket to discuss how to deal with old preferences in a nicer way

@buttercrab
Copy link

@lwouis It's working great!

@gingerr
Copy link
Contributor Author

gingerr commented Apr 8, 2020

@lwouis Can also confirm the fix. Dropdown preferences were pre-selected correctly and changing them works also.

I did not change any preferences in the last few months so I did not observe this earlier. Today i took a look inside to see what new features you have implemented and especially the ShortcutRecorder keybindings.

Thank you! 💯

@gingerr
Copy link
Contributor Author

gingerr commented Apr 8, 2020

How did you fix it? Do you save an english key in the preferences instead of the localised value string now? Or array index of the dropdown option?

Nevermind, found it, array index.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants