-
-
Notifications
You must be signed in to change notification settings - Fork 323
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Better downgrade/upgrade preferences support #220
Comments
@lwouis I just upgraded from 3.6.0 direct to 3.6.2 (via the auto-updater). After the upgrade I could not get alt-tab to launch at all, and it would just silently fail every time I tried. After deleting preferences (via command line) it launched just fine. Another data point for you. |
Yeah, this behavior is pretty much the worse. Silent crash at startup. We really need to avoid that because most users will just give up and uninstall. Even reinstalling doesn't fix, which is really bad |
I'm having the same today. What's the proper fix? Edit: Deleting all config/pref files with AppCleaner did the trick for me. |
@cdbattags yes, sorry about that! I made a hotfix so that users who upgrade now (to 3.7.0+) won't face the crash. I also raised a PR #224 to handle preference migrations rare cases |
# [3.18.0](v3.17.2...v3.18.0) (2020-05-05) ### Bug Fixes * activate shortcuts without updating their userdefaults ([6aad3e7](6aad3e7)) * can close feedback window with escape key ([05fb4a2](05fb4a2)) * correctly display right-to-left languages ([89f2df4](89f2df4)) * more robust preference migrations (closes [#220](#220)) ([bf857e8](bf857e8)) ### Features * add arabic localization ([0a1bb6e](0a1bb6e)) * check for updates weekly instead of daily ([02920a7](02920a7)), closes [#295](#295) * update german localization ([1925777](1925777))
As highlighted in #217, preferences can sometimes crash because of a lack of up/down-grade support. I started adding upgrade support, but I think more can be done.
In particular, I think a catch-all mechanism could be implemented to delete the current preferences if there is no supported path for it. This way the user lose their preferences which is bad, but at least the app doesn't crash on them which is worse.
The text was updated successfully, but these errors were encountered: