Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add config option to disable title capitalization #408

Merged
merged 2 commits into from
Jul 24, 2024

Conversation

ericswpark
Copy link
Contributor

Description

Users can set disableTitleCapitalization to true in order to, well, disable title capitalization.

Issue Number

Fixes #368


Additional Information (Optional)

I wrote this on my phone so it may not work?


Checklist

Yes, I included all necessary artefacts, including:

  • Tests
  • Documentation
  • Implementation (Code and Ressources)
  • Example

Documentation moved to wiki since I last contributed here, so once this PR is merged I guess the wiki could be edited?

Testing Checklist

Yes, I ensured that all of the following scenarios were tested:

  • Desktop Light Mode (Default)
  • Desktop Dark Mode
  • Desktop Light RTL Mode
  • Desktop Dark RTL Mode
  • Mobile Light Mode
  • Mobile Dark Mode
  • Mobile Light RTL Mode
  • Mobile Dark RTL Mode

Notify the following users

Users can set disableTitleCapitalization to true in order to, well,
disable title capitalization.

Fixes lxndrblz#368
@netlify
Copy link

netlify bot commented Dec 17, 2022

👷 Deploy Preview for anatole-demo processing.

Name Link
🔨 Latest commit a5229f8
🔍 Latest deploy log https://app.netlify.com/sites/anatole-demo/deploys/66a12f58a227aa00081dd929

@sonarcloud
Copy link

sonarcloud bot commented Dec 17, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@lxndrblz lxndrblz self-assigned this Mar 27, 2023
@lxndrblz
Copy link
Owner

@ericswpark Thanks for your PR. I wonder if that's really sufficient
Shouldn't the capitalization also be disabled on the portfolio page and in the post series snippet?

@ericswpark
Copy link
Contributor Author

@lxndrblz it really is a rough draft I wrote on my phone so I may have (read: probably will have) missed a ton.

In addition this PR doesn't affect any CSS rules, as noted in the original issue report. I opted not to include it because a) I don't know how to disable CSS rules based on Hugo configuration, and b) we still need to figure out whether to have it configurable in one configuration option or in a separate one.

Copy link
Owner

@lxndrblz lxndrblz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ericswpark LGTM. Thanks for your PR.

Copy link

sonarcloud bot commented Jul 24, 2024

@lxndrblz lxndrblz added the enhancement New feature or request label Jul 24, 2024
@lxndrblz lxndrblz merged commit 297bcc8 into lxndrblz:master Jul 24, 2024
5 checks passed
@lxndrblz lxndrblz mentioned this pull request Jul 24, 2024
12 tasks
@ericswpark ericswpark deleted the disable-title-caps branch July 24, 2024 23:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Disable title capitalization
2 participants