Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(post): add description to list #467

Closed

Conversation

polomarcus
Copy link

@polomarcus polomarcus commented Jun 28, 2023

Description

Page

Post : https://deploy-preview-467--anatole-demo.netlify.app/post/

Change 1 - Add description next to the title

A title can be short to understand what is behind it, adding the description can help.

Change 2 - remove uppercase from post page - linked issue : #368

New York City changed all his street signs to lower case to improve readability : Throughout the City, a New Generation of Street Signs
image

Example 1 - a long description

image

Example 2 - full page example

image

Caution

#466 should not be merged if this PR is selected

Checklist

Yes, I included all necessary artefacts, including:

  • Tests
  • Documentation
  • Implementation (Code and Ressources)
  • Example

Testing Checklist

Yes, I ensured that all of the following scenarios were tested:

  • Desktop Light Mode (Default)
  • Desktop Dark Mode
  • Desktop Light RTL Mode
  • Desktop Dark RTL Mode
  • Mobile Light Mode
  • Mobile Dark Mode
  • Mobile Light RTL Mode
  • Mobile Dark RTL Mode

Notify the following users

@netlify
Copy link

netlify bot commented Jun 28, 2023

Deploy Preview for anatole-demo ready!

Name Link
🔨 Latest commit 0bb5f54
🔍 Latest deploy log https://app.netlify.com/sites/anatole-demo/deploys/649c391973a5280008c417e5
😎 Deploy Preview https://deploy-preview-467--anatole-demo.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@polomarcus polomarcus changed the title Feat/post add description to list feat(post): add description to list Jun 28, 2023
@sonarcloud
Copy link

sonarcloud bot commented Jun 28, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@polomarcus
Copy link
Author

hi @lxndrblz,

If you find some times to review this PR, I'd be happy to exchange with you.

Thanks

@lxndrblz
Copy link
Owner

@polomarcus Thanks for opening up this PR which contains two main ideas.

a) The option to disable the upper casing on the archive page. This change has been implemented through the PR #408
b) I have decided against including a description on the archive page, as this basically turns the archive page in just another blog post listing. Personally, I couldn't see the benefit and I have therefore decided to close this PR.

Nevertheless, Thanks for your support and I am looking forward for any future PRs.

@lxndrblz lxndrblz closed this Jul 24, 2024
@lxndrblz lxndrblz self-assigned this Jul 24, 2024
@lxndrblz lxndrblz added the wontfix This will not be worked on label Jul 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
wontfix This will not be worked on
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants