Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(post): add description to href title #466

Conversation

polomarcus
Copy link

@polomarcus polomarcus commented Jun 28, 2023

Description

If #467 is accepted, this PR should not be merged

Page

post (https://anatole-demo.netlify.app/post/)

Change

The Title data is shown directly inside the <a>Title</a> and at the same time inside the <a title="Title">Title</a>.

To add more metadata to the link i propose to add the description inside the title attribute : <a title="Description">Title</a>

Example 1

image

Example 2 - Dark theme

image

Checklist

Yes, I included all necessary artefacts, including:

  • Tests
  • Documentation
  • Implementation (Code and Ressources)
  • Example

Testing Checklist

Yes, I ensured that all of the following scenarios were tested:

  • Desktop Light Mode (Default)
  • Desktop Dark Mode
  • Desktop Light RTL Mode
  • Desktop Dark RTL Mode
  • Mobile Light Mode
  • Mobile Dark Mode
  • Mobile Light RTL Mode
  • Mobile Dark RTL Mode

@netlify
Copy link

netlify bot commented Jun 28, 2023

Deploy Preview for anatole-demo ready!

Name Link
🔨 Latest commit 19ca44a
🔍 Latest deploy log https://app.netlify.com/sites/anatole-demo/deploys/649c30030c2a9800083c86ae
😎 Deploy Preview https://deploy-preview-466--anatole-demo.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@sonarcloud
Copy link

sonarcloud bot commented Jun 28, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@polomarcus polomarcus mentioned this pull request Jun 28, 2023
12 tasks
@polomarcus polomarcus closed this Dec 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant