Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove save tokens in build auth header #994

Merged

Conversation

MaicolBen
Copy link
Collaborator

@MaicolBen MaicolBen commented Oct 24, 2017

Resolves #992

This will improve the performance of each request in case change_headers_on_each_request is disabled.

@zachfeldman zachfeldman self-requested a review October 24, 2017 14:56
Copy link
Contributor

@zachfeldman zachfeldman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks pretty good and straightforward to me. Seems good to merge!

@zachfeldman
Copy link
Contributor

@MaicolBen since this hasn't moved or had any disapproval, I'd feel free to merge if you're ready!

@MaicolBen
Copy link
Collaborator Author

@zachfeldman I think is good to go!

@lynndylanhurley
Copy link
Owner

Looks good, thanks @MaicolBen!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants