Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove save tokens in build auth header #994

Merged
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 15 additions & 11 deletions app/models/devise_token_auth/concerns/user.rb
Original file line number Diff line number Diff line change
Expand Up @@ -199,17 +199,27 @@ def create_new_auth_token(client_id=nil)
updated_at: Time.now
}

return build_auth_header(token, client_id)
return update_auth_header(token, client_id)
end


def build_auth_header(token, client_id='default')
client_id ||= 'default'

# client may use expiry to prevent validation request if expired
# must be cast as string or headers will break
expiry = self.tokens[client_id]['expiry'] || self.tokens[client_id][:expiry]

return {
DeviseTokenAuth.headers_names[:"access-token"] => token,
DeviseTokenAuth.headers_names[:"token-type"] => "Bearer",
DeviseTokenAuth.headers_names[:"client"] => client_id,
DeviseTokenAuth.headers_names[:"expiry"] => expiry.to_s,
DeviseTokenAuth.headers_names[:"uid"] => self.uid
}
end

def update_auth_header(token, client_id='default')
headers = build_auth_header(token, client_id)
expiry = headers[DeviseTokenAuth.headers_names[:"expiry"]]
max_clients = DeviseTokenAuth.max_number_of_devices
while self.tokens.keys.length > 0 && max_clients < self.tokens.keys.length
oldest_token = self.tokens.min_by { |cid, v| v[:expiry] || v["expiry"] }
Expand All @@ -218,13 +228,7 @@ def build_auth_header(token, client_id='default')

self.save!

return {
DeviseTokenAuth.headers_names[:"access-token"] => token,
DeviseTokenAuth.headers_names[:"token-type"] => "Bearer",
DeviseTokenAuth.headers_names[:"client"] => client_id,
DeviseTokenAuth.headers_names[:"expiry"] => expiry.to_s,
DeviseTokenAuth.headers_names[:"uid"] => self.uid
}
headers
end


Expand All @@ -239,7 +243,7 @@ def build_auth_url(base_url, args)
def extend_batch_buffer(token, client_id)
self.tokens[client_id]['updated_at'] = Time.now

return build_auth_header(token, client_id)
return update_auth_header(token, client_id)
end

def confirmed?
Expand Down