[dbnode] Update return unfulfilled for corrupt commit log files default #2807
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As any forced shutdown of the DB node (via SIGKILL instead of SIGTERM) causes the final commit log entry to be corrupt, all users today use default for this flag. Ahead of 1.0 we should update this value to reflect the usage of this everywhere.
nbroyles
approved these changes
Oct 28, 2020
ryanhall07
reviewed
Oct 28, 2020
| @@ -34,7 +34,7 @@ const ( | |||
| // DefaultReturnUnfulfilledForCorruptCommitLogFiles is the default | |||
| // value for whether to return unfulfilled when encountering corrupt | |||
| // commit log files. | |||
| DefaultReturnUnfulfilledForCorruptCommitLogFiles = true | |||
| DefaultReturnUnfulfilledForCorruptCommitLogFiles = false | |||
There was a problem hiding this comment.
why is this the default we want?
There was a problem hiding this comment.
Added to commit description the link to the corresponding documentation:
https://github.com/m3db/m3/blob/64c6dea950ce27108841ecb82304cf8c46eea158/site/content/docs/operational_guide/availability_consistency_durability.md#ignoring-corrupt-commitlogs-on-bootstrap
ryanhall07
approved these changes
Oct 29, 2020
robskillington
deleted the
r/return-unfulfilled-for-corrupt-commit-log-files
branch
soundvibe
added a commit
that referenced
this pull request
Oct 30, 2020
* master: [query] count_values label naming fixes (#2805) [dbnode] Read only namespaces (#2803) Remove old code: m3nsch (#2822) Update issue templates Update issue templates [proto] Allow zero-alloc reuse of AggregatedMetric protobuf payloads (#2823) Remove old code: aggregator/handler/trafficcontrol (#2821) Remove old code: aggregation/quantile/tdigest (#2820) AddToReset config to change Add transforms to Reset transforms (#2817) [metrics/rules] Add test to assert that mixed-mode keepOriginal uses keepOriginal=true (#2819) [dbnode] Update return unfulfilled for corrupt commit log files default (#2807) [dbnode] Move eviction logic up before ns loop (#2812) [query] Add additional parser tests (#2811) [config] Remove deprecated configuration fields (#2771)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
As any forced shutdown of the DB node (via SIGKILL instead of SIGTERM) causes the final commit log entry to be corrupt, all users today use default for this flag. Ahead of 1.0 we should update this value to reflect the usage of this everywhere.
For more information see the following:
https://github.com/m3db/m3/blob/64c6dea950ce27108841ecb82304cf8c46eea158/site/content/docs/operational_guide/availability_consistency_durability.md#ignoring-corrupt-commitlogs-on-bootstrap
Special notes for your reviewer:
Does this PR introduce a user-facing and/or backwards incompatible change?:
Does this PR require updating code package or user-facing documentation?: