[dbnode] Read only namespaces #2803
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
linasm
changed the title
arnikola
reviewed
Oct 30, 2020
src/dbnode/namespace/types.go
Outdated
| @@ -213,7 +213,7 @@ type SchemaRegistry interface { | |||
|
|
|||
| // Metadata represents namespace metadata information | |||
| type Metadata interface { | |||
| // Equal returns true if the provide value is equal to this one | |||
| // Equal returns true if the provided value is equal to this one | |||
There was a problem hiding this comment.
nit; mind adding . to all of these including the existing ones?
arnikola
reviewed
Oct 30, 2020
src/dbnode/storage/namespace.go
Outdated
| @@ -1256,7 +1266,7 @@ func (n *dbNamespace) ColdFlush(flushPersist persist.FlushPreparer) error { | |||
|
|
|||
| // If repair is enabled we still need cold flush regardless of whether cold writes is | |||
| // enabled since repairs are dependent on the cold flushing logic. | |||
| if !n.nopts.ColdWritesEnabled() && !n.nopts.RepairEnabled() { | |||
| if n.ReadOnly() || !(n.nopts.ColdWritesEnabled() || n.nopts.RepairEnabled()) { | |||
There was a problem hiding this comment.
nit; may be clearer to read as the following so the logic is more explicit
repairEnabled := !n.nopts.ColdWritesEnabled() && !n.nopts.RepairEnabled()
if n.ReadOnly() || repairEnabled {
There was a problem hiding this comment.
Will do it, but in a bit different way.
soundvibe
added a commit
that referenced
this pull request
Oct 30, 2020
* master: [query] count_values label naming fixes (#2805) [dbnode] Read only namespaces (#2803) Remove old code: m3nsch (#2822) Update issue templates Update issue templates [proto] Allow zero-alloc reuse of AggregatedMetric protobuf payloads (#2823) Remove old code: aggregator/handler/trafficcontrol (#2821) Remove old code: aggregation/quantile/tdigest (#2820) AddToReset config to change Add transforms to Reset transforms (#2817) [metrics/rules] Add test to assert that mixed-mode keepOriginal uses keepOriginal=true (#2819) [dbnode] Update return unfulfilled for corrupt commit log files default (#2807) [dbnode] Move eviction logic up before ns loop (#2812) [query] Add additional parser tests (#2811) [config] Remove deprecated configuration fields (#2771)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Adds support for read only namespaces.
Special notes for your reviewer:
Does this PR introduce a user-facing and/or backwards incompatible change?:
NONE
Does this PR require updating code package or user-facing documentation?:
NONE