Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP [dbnode] Prevent bootstrap of shared rev. index #2810

Closed
wants to merge 14 commits into from

Conversation

linasm
Copy link
Collaborator

@linasm linasm commented Oct 28, 2020

What this PR does / why we need it:

Fixes #

Special notes for your reviewer:
Based on #2803 (read only namespaces)

Does this PR introduce a user-facing and/or backwards incompatible change?:


Does this PR require updating code package or user-facing documentation?:


@codecov
Copy link

codecov bot commented Nov 16, 2020

Codecov Report

Merging #2810 (9fb631e) into master (7e31044) will increase coverage by 0.8%.
The diff coverage is 92.3%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #2810     +/-   ##
=========================================
+ Coverage    71.3%    72.2%   +0.8%     
=========================================
  Files        1079     1115     +36     
  Lines       98596   100525   +1929     
=========================================
+ Hits        70389    72611   +2222     
+ Misses      23253    22977    -276     
+ Partials     4954     4937     -17     
Flag Coverage Δ
aggregator 76.0% <ø> (-0.1%) ⬇️
cluster 85.0% <ø> (-0.1%) ⬇️
collector 84.3% <ø> (ø)
dbnode 79.5% <92.3%> (+3.8%) ⬆️
m3em 74.4% <ø> (ø)
m3ninx 73.0% <ø> (-0.2%) ⬇️
m3nsch 51.1% <ø> (?)
metrics 17.2% <ø> (-2.7%) ⬇️
msg 74.2% <ø> (ø)
query 69.2% <ø> (+0.3%) ⬆️
x 80.5% <ø> (+0.5%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7e31044...a778ed2. Read the comment docs.

@linasm linasm closed this Dec 1, 2020
@linasm linasm deleted the linasm/prevent-shared-rev-index-bootstrap branch December 1, 2020 07:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant