Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump go to 1.14 #2853

Merged
merged 3 commits into from
Nov 7, 2020
Merged

Bump go to 1.14 #2853

merged 3 commits into from
Nov 7, 2020

Conversation

vdarulis
Copy link
Collaborator

@vdarulis vdarulis commented Nov 7, 2020 •
edited
Loading

What this PR does / why we need it:

I've landed all fixes to pass build/tests back in September, this PR switches build to use 1.14, so we don't introduce any more regressions.
Fixes #2540

Special notes for your reviewer:

Does this PR introduce a user-facing and/or backwards incompatible change?:

Does this PR require updating code package or user-facing documentation?:

Upgrade to Go 1.14

@codecov
Copy link

codecov bot commented Nov 7, 2020

Codecov Report

Merging #2853 (01a2a75) into master (30b81ca) will decrease coverage by 17.4%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #2853      +/-   ##
=========================================
- Coverage    71.9%   54.4%   -17.5%     
=========================================
  Files        1099     499     -600     
  Lines      100823   56166   -44657     
=========================================
- Hits        72541   30582   -41959     
+ Misses      23318   22693     -625     
+ Partials     4964    2891    -2073
Flag Coverage Δ
aggregator 52.7% <ø> (-23.2%) ⬇️
cluster ?
collector 45.6% <ø> (-38.7%) ⬇️
dbnode 61.4% <ø> (-18.1%) ⬇️
m3em ?
m3ninx ?
metrics 17.2% <ø> (ø)
msg ?
query ?
x ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 30b81ca...0f69a67. Read the comment docs.

andrewmains12
andrewmains12 approved these changes Nov 7, 2020
View reviewed changes
Copy link
Contributor

@andrewmains12 andrewmains12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this! My assumptions are that we're good if the build passes, i.e. that means the race issues are fixed (looks like yes). I guess there's always the potential for runtime issues, but iirc we've been actually running on Go 1.14 for a bit, so should be good.

@vdarulis vdarulis merged commit 55e6e44 into master Nov 7, 2020
@vdarulis vdarulis deleted the v/go_114 branch November 7, 2020 18:27
@robskillington
Copy link
Collaborator

robskillington commented Nov 9, 2020 •
edited
Loading

Thanks for getting CI fixed on 1.14 Vytenis, quite a challenge.

@vdarulis
Copy link
Collaborator Author

vdarulis commented Nov 9, 2020

np, my bad for dropping the ball, since all prerequisites were merged a long while ago.

soundvibe added a commit that referenced this pull request Nov 11, 2020
@soundvibe
Merge branch 'master' into linasn/query-handlers-refactoring
1fe3aa1 
* master: (28 commits)
  [dbnode] Add claims for index segments volume index (#2846)
  [dbnode] Remove namespaces from example config and integration tests (#2866)
  [dbnode] Resurrect flaky test skip (#2868)
  [aggregator] Fix checkCampaignStateLoop (#2867)
  [dbnode] implement deletion method in namespace kvadmin service (#2861)
  Replace closer with resource package (#2864)
  Add coding style guide (#2831)
  Add GOVERNANCE.md to describe governance (#2830)
  Add COMPATIBILITY.md to describe version compatibility (#2829)
  Refactor etcd config as discovery section with convenience types (#2843)
  Refactor x/lockfile into dbnode/server (#2862)
  [lint] Disable nlreturn linter (#2865)
  [m3cluster] Expose placement algorithm in placement service (#2858)
  [etcd] Set reasonable cluster connection/sync settings by default (#2860)
  [dbnode] Use bits.LeadingZeros64 to improve encoder performance (#2857)
  Cleanup m3nsch leftovers (#2856)
  Update ci-scripts to correct coverage tracking (#2854)
  [aggregator] Process campaign state without waiting for first campaign check interval (#2855)
  Bump go to 1.14 (#2853)
  [query] Remove single series error from M3
  ...
vdarulis added a commit that referenced this pull request Nov 12, 2020
@vdarulis
Revert "Bump go to 1.14 (#2853)"
34d747a 
This reverts commit 55e6e44.
robskillington pushed a commit that referenced this pull request Nov 12, 2020
@vdarulis
Revert "Bump go to 1.14 (#2853)" (#2885)
b51a695 
We'll upgrade Go runtime immediately after 1.0 release, we're still waiting on a few more end users to sign off on performance under Go 1.14 (we'll likely move directly to evaluating performance under Go 1.15 with end users instead).
robskillington pushed a commit that referenced this pull request Nov 12, 2020
@vdarulis @robskillington
Revert "Bump go to 1.14 (#2853)" (#2885)
3cf877e 
We'll upgrade Go runtime immediately after 1.0 release, we're still waiting on a few more end users to sign off on performance under Go 1.14 (we'll likely move directly to evaluating performance under Go 1.15 with end users instead).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrewmains12 andrewmains12 andrewmains12 approved these changes

@mway mway Awaiting requested review from mway

@prateek prateek Awaiting requested review from prateek

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make M3 monorepo compatible with Go 1.14
3 participants
@vdarulis @robskillington @andrewmains12