Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dbnode] Resurrect flaky test skip #2868

Merged
merged 2 commits into from
Nov 10, 2020
Merged

Conversation

linasm
Copy link
Collaborator

@linasm linasm commented Nov 10, 2020

What this PR does / why we need it:
Had accidentally uncommented a Skip on a flaky test while checking it locally. Reverting.

Special notes for your reviewer:

Does this PR introduce a user-facing and/or backwards incompatible change?:
NONE

Does this PR require updating code package or user-facing documentation?:
NONE

@codecov
Copy link

codecov bot commented Nov 10, 2020

Codecov Report

Merging #2868 (47cde34) into master (47cde34) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #2868   +/-   ##
======================================
  Coverage    72.1%   72.1%           
======================================
  Files        1100    1100           
  Lines       99971   99971           
======================================
  Hits        72129   72129           
  Misses      22900   22900           
  Partials     4942    4942           
Flag Coverage Δ
aggregator 75.8% <0.0%> (ø)
cluster 85.0% <0.0%> (ø)
collector 84.3% <0.0%> (ø)
dbnode 79.3% <0.0%> (ø)
m3em 74.4% <0.0%> (ø)
m3ninx 73.1% <0.0%> (ø)
metrics 17.2% <0.0%> (ø)
msg 74.0% <0.0%> (ø)
query 68.8% <0.0%> (ø)
x 80.4% <0.0%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 47cde34...55a26e7. Read the comment docs.

@linasm linasm merged commit a0a4c61 into master Nov 10, 2020
@linasm linasm deleted the linasm/resurrect-test-skip branch November 10, 2020 08:08
soundvibe added a commit that referenced this pull request Nov 11, 2020
* master: (28 commits)
  [dbnode] Add claims for index segments volume index (#2846)
  [dbnode] Remove namespaces from example config and integration tests (#2866)
  [dbnode] Resurrect flaky test skip (#2868)
  [aggregator] Fix checkCampaignStateLoop (#2867)
  [dbnode] implement deletion method in namespace kvadmin service (#2861)
  Replace closer with resource package (#2864)
  Add coding style guide (#2831)
  Add GOVERNANCE.md to describe governance (#2830)
  Add COMPATIBILITY.md to describe version compatibility (#2829)
  Refactor etcd config as discovery section with convenience types (#2843)
  Refactor x/lockfile into dbnode/server (#2862)
  [lint] Disable nlreturn linter (#2865)
  [m3cluster] Expose placement algorithm in placement service (#2858)
  [etcd] Set reasonable cluster connection/sync settings by default (#2860)
  [dbnode] Use bits.LeadingZeros64 to improve encoder performance (#2857)
  Cleanup m3nsch leftovers (#2856)
  Update ci-scripts to correct coverage tracking (#2854)
  [aggregator] Process campaign state without waiting for first campaign check interval (#2855)
  Bump go to 1.14 (#2853)
  [query] Remove single series error from M3
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants