Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[aggregator] Reduce error handling overhead in rawtcp server #3183

Merged
merged 1 commit into from
Feb 7, 2021

Conversation

vdarulis
Copy link
Collaborator

@vdarulis vdarulis commented Feb 7, 2021

What this PR does / why we need it:

The errors escape to the heap for no good reason, and makes rate-limiting more expensive than it should be:

src/aggregator/server/rawtcp/server.go:146:27: addUntimedError literal escapes to heap
src/aggregator/server/rawtcp/server.go:150:27: addUntimedError literal escapes to heap
src/aggregator/server/rawtcp/server.go:154:27: addUntimedError literal escapes to heap
src/aggregator/server/rawtcp/server.go:158:29: addForwardedError literal escapes to heap
src/aggregator/server/rawtcp/server.go:162:25: addTimedError literal escapes to heap
src/aggregator/server/rawtcp/server.go:166:25: addTimedError literal escapes to heap
src/aggregator/server/rawtcp/server.go:170:31: addPassthroughError literal escapes to heap

Special notes for your reviewer:

Does this PR introduce a user-facing and/or backwards incompatible change?:


Does this PR require updating code package or user-facing documentation?:


@codecov
Copy link

codecov bot commented Feb 7, 2021

Codecov Report

Merging #3183 (0fac338) into master (f6450c1) will increase coverage by 0.0%.
The diff coverage is 85.7%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #3183     +/-   ##
=========================================
  Coverage    72.2%    72.3%             
=========================================
  Files        1087     1086      -1     
  Lines      101840   100417   -1423     
=========================================
- Hits        73592    72617    -975     
+ Misses      23161    22752    -409     
+ Partials     5087     5048     -39     
Flag Coverage Δ
aggregator 75.8% <85.7%> (+0.1%) ⬆️
cluster 85.0% <ø> (ø)
collector 84.3% <ø> (ø)
dbnode 78.7% <ø> (+0.3%) ⬆️
m3em 74.4% <ø> (ø)
m3ninx 73.1% <ø> (-0.2%) ⬇️
metrics 20.0% <ø> (ø)
msg 74.2% <ø> (-0.1%) ⬇️
query 67.3% <ø> (ø)
x 80.2% <ø> (-0.5%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f6450c1...0fac338. Read the comment docs.

@vdarulis vdarulis merged commit 1c3debf into master Feb 7, 2021
@vdarulis vdarulis deleted the v/aggsrc branch February 7, 2021 05:44
soundvibe added a commit that referenced this pull request Feb 10, 2021
* master: (30 commits)
  [dbnode] Use go context to cancel index query workers after timeout (#3194)
  [aggregator] Fix change ActivePlacement semantics on close (#3201)
  [aggregator] Simplify (Active)StagedPlacement API (#3199)
  [aggregator] Checking if metadata is set to default should not cause copying (#3198)
  [dbnode] Remove readers and writer from aggregator API (#3122)
  [aggregator] Avoid large copies in entry rollup comparisons by making them more inline-friendly (#3195)
  [dbnode] Re-add aggregator doc limit update (#3137)
  [m3db] Do not close reader in filterFieldsIterator.Close() (#3196)
  Revert "Remove disk series read limit (#3174)" (#3193)
  [instrument] Improve sampled timer and stopwatch performance (#3191)
  Omit unset fields in metadata json (#3189)
  [dbnode] Remove left-over code in storage/bootstrap/bootstrapper (#3190)
  [dbnode][coordinator] Support match[] in label endpoints (#3180)
  Instrument the worker pool with the wait time (#3188)
  Instrument query path (#3182)
  [aggregator] Remove indirection, large copy from unaggregated protobuf decoder (#3186)
  [aggregator] Sample timers completely (#3184)
  [aggregator] Reduce error handling overhead in rawtcp server (#3183)
  [aggregator] Move shardID calculation out of critical section (#3179)
  Move instrumentation cleanup to FetchTaggedResultIterator Close() (#3173)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants