[aggregator] Simplify (Active)StagedPlacement API #3199
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #3199 +/- ##
=========================================
- Coverage 72.2% 72.2% -0.1%
=========================================
Files 1087 1087
Lines 100714 100686 -28
=========================================
- Hits 72816 72774 -42
- Misses 22838 22846 +8
- Partials 5060 5066 +6
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
mway
reviewed
Feb 9, 2021
| @@ -34,38 +33,36 @@ import ( | |||
| var ( | |||
| errNoApplicablePlacement = errors.New("no applicable placement found") | |||
| errActiveStagedPlacementClosed = errors.New("active staged placement is closed") | |||
| errPlacementInvalidType = errors.New("type assertion failed, corrupt placement") | |||
There was a problem hiding this comment.
nit: type assertion is an implementation detail, this can probably just be "corrupt placement"
| ) | ||
|
|
||
| type activeStagedPlacement struct { | ||
| sync.RWMutex | ||
| var _noPlacements Placements |
There was a problem hiding this comment.
nit: group this with the errors, just put a break between 'em
Comment on lines
42
to
48
| placements atomic.Value | ||
| version int | ||
| nowFn clock.NowFn | ||
| onPlacementsAddedFn OnPlacementsAddedFn | ||
| onPlacementsRemovedFn OnPlacementsRemovedFn | ||
|
|
||
| expiring atomic.Int32 | ||
| closed bool | ||
| doneFn DoneFn | ||
| expiring atomic.Int32 | ||
| closed atomic.Bool |
There was a problem hiding this comment.
probably not much value in memory-aligning, so mind sorting these?
| return errActiveStagedPlacementClosed | ||
| } | ||
| if p.onPlacementsRemovedFn != nil { | ||
| p.onPlacementsRemovedFn(p.placements) | ||
| pl, ok := p.placements.Load().(Placements) |
There was a problem hiding this comment.
do you think it's worth adding a quick note that we understand that pl is still subject to mutability races, it's expected based on historical design, something to that effect?
|
|
||
| func (p *activeStagedPlacement) activePlacementWithLock(timeNanos int64) (Placement, error) { | ||
| if p.closed { | ||
| if p.closed.Load() { |
There was a problem hiding this comment.
nit: do this before the loading placements
mway
approved these changes
Feb 9, 2021
abliqo
reviewed
Feb 9, 2021
| @@ -34,38 +33,36 @@ import ( | |||
| var ( | |||
| errNoApplicablePlacement = errors.New("no applicable placement found") | |||
| errActiveStagedPlacementClosed = errors.New("active staged placement is closed") | |||
| errPlacementInvalidType = errors.New("corrupt placement") | |||
|
|
|||
| _noPlacements Placements | |||
There was a problem hiding this comment.
ultra-nit: _emptyPlacements would read better.
abliqo
approved these changes
Feb 9, 2021
soundvibe
added a commit
that referenced
this pull request
Feb 10, 2021
* master: (30 commits) [dbnode] Use go context to cancel index query workers after timeout (#3194) [aggregator] Fix change ActivePlacement semantics on close (#3201) [aggregator] Simplify (Active)StagedPlacement API (#3199) [aggregator] Checking if metadata is set to default should not cause copying (#3198) [dbnode] Remove readers and writer from aggregator API (#3122) [aggregator] Avoid large copies in entry rollup comparisons by making them more inline-friendly (#3195) [dbnode] Re-add aggregator doc limit update (#3137) [m3db] Do not close reader in filterFieldsIterator.Close() (#3196) Revert "Remove disk series read limit (#3174)" (#3193) [instrument] Improve sampled timer and stopwatch performance (#3191) Omit unset fields in metadata json (#3189) [dbnode] Remove left-over code in storage/bootstrap/bootstrapper (#3190) [dbnode][coordinator] Support match[] in label endpoints (#3180) Instrument the worker pool with the wait time (#3188) Instrument query path (#3182) [aggregator] Remove indirection, large copy from unaggregated protobuf decoder (#3186) [aggregator] Sample timers completely (#3184) [aggregator] Reduce error handling overhead in rawtcp server (#3183) [aggregator] Move shardID calculation out of critical section (#3179) Move instrumentation cleanup to FetchTaggedResultIterator Close() (#3173) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This simplifies staged placement API and significantly reduces contention (placement is fetched for each metric write).
Special notes for your reviewer:
Does this PR introduce a user-facing and/or backwards incompatible change?:
Does this PR require updating code package or user-facing documentation?: