Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The PR aims to improve the handling of WATCH_NAMESPACE param when ins… #202

Merged
merged 2 commits into from
Jun 6, 2021
Merged

The PR aims to improve the handling of WATCH_NAMESPACE param when ins… #202

merged 2 commits into from
Jun 6, 2021

Conversation

Kaitou786
Copy link
Collaborator

…talling from OLM.

OLM doesn't set any env var for us, so earlier whenever someone installs the operator in a specific namespace
The operator would still run in cluster wide, since the WATCH_NAMESPACE var was not found.

Signed-off-by: Tarun Khandelwal tarkhand@redhat.com

The PR aims to improve the handling of WATCH_NAMESPACE param when ins…
44eaf16 
…talling from OLM.

OLM doesn't set any env var for us, so earlier whenever someone installs the operator in a specific namespace
The operator would still run in cluster wide, since the WATCH_NAMESPACE var was not found.

Signed-off-by: Tarun Khandelwal <tarkhand@redhat.com>
@Kaitou786 Kaitou786 force-pushed the fix-targetnamespace branch from 59c2e2b to 44eaf16 Compare January 12, 2021 07:24
@ricardozanini ricardozanini added the openshift This issue/PR is related to OpenShift deployments only label Jan 12, 2021
@ricardozanini
Copy link
Member

The integration check is supposed to fail due to their changes, right @Kaitou786 ?

@Kaitou786
Copy link
Collaborator Author

Kaitou786 commented Jan 12, 2021 •
edited
Loading

@ricardozanini Well not sure, it could be due to the bug we have right now in our CI system.
The current operator version is set to 0.5.0 on master. But we already have 0.5.0 released on nexus-operator community operators and we copy this as defined here Which is leading to the error about having 2 CSVs.
The solution would be to bump our master to next version.

@ricardozanini
Copy link
Member

@Kaitou786 indeed. I haven't seen the logs, shame on me. I'll send a PR to upgrade to 0.6.0. Many thanks!

LCaparelli
LCaparelli approved these changes Jan 13, 2021
View reviewed changes
Copy link
Member

@LCaparelli LCaparelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Kaitou786!

@ricardozanini
Copy link
Member

@Kaitou786 indeed. I haven't seen the logs, shame on me. I'll send a PR to upgrade to 0.6.0. Many thanks!

Waiting for OLM to merge our 0.5.0 PR.

@Kaitou786
Copy link
Collaborator Author

Okay, no worries :)

@LCaparelli
Copy link
Member

I bumped the version to 0.6.0 on #206, this should be ready to go once that's merged

@ricardozanini ricardozanini merged commit 5018327 into m88i:main Jun 6, 2021
@Kaitou786 Kaitou786 deleted the fix-targetnamespace branch June 7, 2021 03:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ricardozanini ricardozanini ricardozanini approved these changes

@LCaparelli LCaparelli LCaparelli approved these changes

Assignees
No one assigned
Labels
openshift This issue/PR is related to OpenShift deployments only
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Kaitou786 @ricardozanini @LCaparelli