-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add way to provide annotations to ingress/route resources #206
Conversation
Signed-off-by: Lucas Caparelli <lucas.caparelli112@gmail.com>
Signed-off-by: Lucas Caparelli <lucas.caparelli112@gmail.com>
@@ -25,7 +25,7 @@ jobs: | |||
with: | |||
# Required: the version of golangci-lint is required and must be specified without patch version: we always use the latest patch version. | |||
version: latest | |||
args: --enable=golint --timeout=2m | |||
args: --enable=revive --timeout=2m --skip-files=pkg/test/client.go,pkg/framework/kind/kinds.go,controllers/nexus/resource/validation/defaults.go |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
golint was deprecated, hence the change to revive
.
fake
, which we use on pkg/test/client.go
was also deprecated, so I added it to the skip list until a more definitive solution.
The other two files are full of constants and vars which are sufficiently described by their names. Adding comments would render pearls like:
// NexusCommunityImage is the community image of Nexus
NexusCommunityImage = "docker.io/sonatype/nexus3"
Not very productive, so I added them to the skip list.
Dunno what's up with the tests, ran fine locally. I'll have a look later |
Maybe this?
|
Signed-off-by: Lucas Caparelli <lucas.caparelli112@gmail.com>
Signed-off-by: Lucas Caparelli <lucas.caparelli112@gmail.com>
5347018
to
ff89cfd
Compare
Turns out the Makefile recipe we were using fetched the script from the master branch, but that script was broken into separate files, so it got a 404 when trying to download it. I changed the recipe to fetch the script from controller-runtime v0.6.3, which should work fine with our current version of the SDK. |
Signed-off-by: Lucas Caparelli <lucas.caparelli112@gmail.com>
#sed -i "s,#\!.*,#\!\/bin\/bash,g" ${ENVTEST_ASSETS_DIR}/setup-envtest.sh | ||
#sed -i "/pipefail/d" ${ENVTEST_ASSETS_DIR}/setup-envtest.sh |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Afraid to remove them completely? 😆
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well, I didn't want to remove since it was created by the SDK, should cause less confusion when migrating to newer versions (i.e., the code block will be there, though commented out vs. not having the lines at all)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh no, I added this to fix an error in their script. I believe I should've sent a PR instead. We can remove these lines.
I'm gonna merge to clear the way for the others PRs, we can remove the |
Fix #205
Relates to #200
Signed-off-by: Lucas Caparelli lucas.caparelli112@gmail.com