Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow setting host and labels for Route/Ingress #207

Merged
merged 11 commits into from
Jun 6, 2021
Merged

Allow setting host and labels for Route/Ingress #207

merged 11 commits into from
Jun 6, 2021

Conversation

LCaparelli
Copy link
Member

Blocked by #206
Fix #200

Changelog:

  • Route objects are now created with spec.host defined by the Nexus CR's spec.networking.host field
  • Route and Ingress objects now inherit labels from spec.networking.labels

LCaparelli added 9 commits June 2, 2021 20:15
@LCaparelli
Add way to provide annotations to ingress/route resources
c770190 
Signed-off-by: Lucas Caparelli <lucas.caparelli112@gmail.com>
@LCaparelli
Fix lint issues
9c23d74 
Signed-off-by: Lucas Caparelli <lucas.caparelli112@gmail.com>
@LCaparelli
Fix CI sdk and go version
2706d36 
Signed-off-by: Lucas Caparelli <lucas.caparelli112@gmail.com>
@LCaparelli
Get envtest setup script from specific controller-runtime version
ff89cfd 
Signed-off-by: Lucas Caparelli <lucas.caparelli112@gmail.com>
@LCaparelli
Change version to 0.6.0
b92e7d9 
Signed-off-by: Lucas Caparelli <lucas.caparelli112@gmail.com>
@LCaparelli
Use spec.networking.host on routes
ad13367 
Signed-off-by: Lucas Caparelli <lucas.caparelli112@gmail.com>
@LCaparelli
Add way to provide labels to route/ingress resources
6908658 
Signed-off-by: Lucas Caparelli <lucas.caparelli112@gmail.com>
@LCaparelli
Document networking annotations and labels
51589a2 
Signed-off-by: Lucas Caparelli <lucas.caparelli112@gmail.com>
@LCaparelli
Add host configuration feature for routes
87af090 
Signed-off-by: Lucas Caparelli <lucas.caparelli112@gmail.com>
@LCaparelli LCaparelli added this to the v0.6.0 milestone Jun 6, 2021
@LCaparelli
Auto-generated changes
b42a698 
Signed-off-by: Lucas Caparelli <lucas.caparelli112@gmail.com>
@LCaparelli LCaparelli requested a review from ricardozanini June 6, 2021 00:58
@ricardozanini ricardozanini merged commit 4fc6611 into m88i:main Jun 6, 2021
@ricardozanini ricardozanini added kubernetes This issue/PR is related to Kubernetes deployments only openshift This issue/PR is related to OpenShift deployments only labels Jun 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ricardozanini ricardozanini ricardozanini approved these changes

Assignees
No one assigned
Labels
kubernetes This issue/PR is related to Kubernetes deployments only openshift This issue/PR is related to OpenShift deployments only
Projects
None yet
Milestone
v0.6.0
Development

Successfully merging this pull request may close these issues.

OpenShift: Allow to configure "host" in the "route" manifest
2 participants
@LCaparelli @ricardozanini