refactor: Migrate Instance Manager Tests to TypeScript #953
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexs-mparticle
added
wait to merge
refactor
alexs-mparticle
force-pushed
the
refactor/SQDSDKS-6771-mp-instance-manager-tests
branch
from
254cdd0
to
d092629
Compare
rmi22186
requested changes
Nov 26, 2024
src/sdkRuntimeModels.ts
Outdated
| @@ -189,7 +197,7 @@ export interface MParticleWebSDK { | |||
| getDeviceId(): string; | |||
| setDeviceId(deviceId: string): void; | |||
| setSessionAttribute(key: string, value: string): void; | |||
| getInstance(): MParticleWebSDK; // TODO: Create a new type for MParticleWebSDKInstance | |||
| getInstance(instanceName?: string): MParticleWebSDK; // TODO: Create a new type for MParticleWebSDKInstance | |||
There was a problem hiding this comment.
nice catch on missing argument here!
add an mp work item for this instead please.
There was a problem hiding this comment.
I think we should possibly do this as part of https://go.mparticle.com/work/SQDSDKS-4804
src/sdkRuntimeModels.ts
Outdated
| @@ -207,6 +215,7 @@ export interface MParticleWebSDK { | |||
| ProductActionType: SDKProductActionType; | |||
| generateHash(value: string): string; | |||
| isIOS?: boolean; | |||
| sessionManager: Pick<ISessionManager, 'getSession'>; | |||
There was a problem hiding this comment.
can we also add a work item, or perhaps add to the V3 item about making the public API for this better? perhaps we only need to put getSession on the instance and not require a customer to use mp.sessionManager.getSession(). not a decision, but just something to flag given it's just 1 method.
There was a problem hiding this comment.
Comment on lines
+99
to
+107
| 'Other5', | ||
| 'Other6', | ||
| 'Other7', | ||
| 'Other8', | ||
| 'Other9', | ||
| 'Other10', | ||
| 'MobileNumber', | ||
| 'PhoneNumber2', | ||
| 'PhoneNumber3', |
rmi22186
approved these changes
Nov 27, 2024
alexs-mparticle
force-pushed
the
refactor/SQDSDKS-6771-mp-instance-manager-tests
branch
from
0d6a2a7
to
1cf2faf
Compare
|
alexs-mparticle
merged commit 802b639
into
refactor/ts-migration-blackout-2024
31 of 35 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instructions
developmentSummary
Testing Plan
Reference Issue (For mParticle employees only. Ignore if you are an outside contributor)