Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: Migrate Instance Manager Tests to TypeScript #953

Merged
merged 3 commits into from
Nov 27, 2024
Merged

refactor: Migrate Instance Manager Tests to TypeScript #953

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e24a4b2
refactor: Migrate Instance Manager Tests to TypeScript
alexs-mparticle Nov 25, 2024
1cf2faf
Address PR Comments
alexs-mparticle Nov 27, 2024
b031d49
Update IdentityType test after rebase
alexs-mparticle Nov 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 11 additions & 2 deletions src/sdkRuntimeModels.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,12 @@ import {
IdentityCallback,
ISDKUserAttributes,
} from './identity-user-interfaces';
import { IdentityType } from './types';
import {
CommerceEventType,
EventType,
IdentityType,
PromotionActionType,
} from './types';
import IntegrationCapture from './integrationCapture';
import { INativeSdkHelpers } from './nativeSdkHelpers.interfaces';
import { ICookieSyncManager, IPixelConfiguration } from './cookieSyncManager.interfaces';
Expand Down Expand Up @@ -154,6 +159,9 @@ export interface MParticleWebSDK {
addForwarder(mockForwarder: MPForwarder): void;
_IntegrationCapture: IntegrationCapture;
IdentityType: valueof<typeof IdentityType>;
CommerceEventType: valueof<typeof CommerceEventType>;
EventType: valueof<typeof EventType>;
PromotionType: valueof<typeof PromotionActionType>;
_Identity: IIdentity;
Identity: SDKIdentityApi;
Logger: SDKLoggerApi;
Expand Down Expand Up @@ -188,7 +196,7 @@ export interface MParticleWebSDK {
getDeviceId(): string;
setDeviceId(deviceId: string): void;
setSessionAttribute(key: string, value: string): void;
getInstance(): MParticleWebSDK; // TODO: Create a new type for MParticleWebSDKInstance
getInstance(instanceName?: string): MParticleWebSDK; // https://go.mparticle.com/work/SQDSDKS-4804
ServerModel();
upload();
setLogLevel(logLevel: LogLevelType): void;
Expand All @@ -206,6 +214,7 @@ export interface MParticleWebSDK {
ProductActionType: SDKProductActionType;
generateHash(value: string): string;
isIOS?: boolean;
sessionManager: Pick<ISessionManager, 'getSession'>; // https://go.mparticle.com/work/SQDSDKS-6949
}

// Used in cases where server requires booleans as strings
Expand Down
2 changes: 1 addition & 1 deletion test/src/_test.index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@
import './config/setup';

// Import each test module
import './tests-mparticle-instance-manager';
import './tests-identity';
import './tests-batchUploader';
import './tests-core-sdk';
Expand All @@ -23,7 +24,6 @@ import './tests-mParticleUser';
import './tests-self-hosting-specific';
import './tests-runtimeToBatchEventsDTO';
import './tests-apiClient';
import './tests-mparticle-instance-manager';
import './tests-queue-public-methods';
import './tests-batchUploader_3';
import './tests-validators';
Expand Down
Loading
Loading