Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Xcode project #1178

Merged
merged 1 commit into from
Apr 1, 2021
Merged

Update Xcode project #1178

merged 1 commit into from
Apr 1, 2021

Conversation

ichizok
Copy link
Member

@ichizok ichizok commented Mar 24, 2021

  • Organize Vim sources
  • Enable Base Internationalization
  • Set "ALWAYS_SEARCH_USER_PATHS" to NO

@ychin
Copy link
Member

ychin commented Mar 25, 2021

@ichizok, is there a reason you are updating for the 2 external libraries: PSMTabBarControl and qlstephen? I think this would make updating in the future more difficult.

Incidentally, I do have some thoughts on each of these:

  • PSMTabBarControl: I think we should probably leave it alone before Tabs #1120 is going to replace it. Maybe leave it alone or wait till Tabs #1120 is merged and see if we need to do anything for the new tabs project?
  • qlstephen: I would actually like to remove it. It's a separate project and introduces system behavior like adding Quick Look for normal files that I'm not sure if I think should be MacVim's responsibility. Still investigating this though.

@ichizok
Copy link
Member Author

ichizok commented Mar 25, 2021

About PSMTabBarControl and qlstephen, because I only have felt their build warning is annoying.
I will revert them since it is not particularly necessary.

- Organize Vim sources
- Enable Base Internationalization
- Set "ALWAYS_SEARCH_USER_PATHS" to NO
@ychin
Copy link
Member

ychin commented Mar 25, 2021

Ok thanks. MacVim has a lot of cruft like these that are using features deprecated years ago… It's a good thing to fix them up.

Speaking of qlstephen, do you have any thoughts on it (or even know what it does)? I'm still deciding on what to do with it but if you don't have any opinions on it that's fine too.

@eirnym
Copy link
Contributor

eirnym commented Mar 26, 2021

@ychin I use it to be honest to preview almost every file I have. Can you suggest an alternative if you're going to delete it?

@ychin
Copy link
Member

ychin commented Mar 26, 2021

@eirnym Why can't your just install qlstephen separately from MacVim? Or is it that you want to preview files that you associated with MacVim? As I said I actually haven't really looked closely into this yet to have made a decision, but I don't think MacVim should inject non-MacVim features, such as the ability to preview a file with no extensions like README. What kind of files are you trying to preview?

Also, do note that qlstephen isn't previewing the files using MacVim. It's basically a raw text preview of the file without any Vim functionality.

I'm looking into qlstephen mostly because I'm looking into #916 btw.

@eirnym
Copy link
Contributor

eirnym commented Mar 27, 2021

ah, you mean files with no extensions... I usually don't look into these files. If I'd want to look into them, I could open them in MacVim by dragging them into.

I mostly do a preview for files with known extensions like markdown, asciidoc, subtitles (ssa/srt/ass), text (which is always set to default for MacVim for me), json/xml and files with code (c/c++/c#/go/rust/python. On few macOs machines I don't have Xcode at all and MacVim is mostly the only source of quick view for these files I have

With this I'd prefer the situation where a way to limit QL extension for a limited number of file types will be found leaving an ability for that in MacVim

@ychin
Copy link
Member

ychin commented Apr 1, 2021

Yeah ok that's mostly what I though @eirnym. Basically #126. Yeah I don't intend to break that, hence I'm still looking at what the best solution is. It may still be including qlstephen but with some modifications so it doesn't hijack the default behaviors for files with no extensions.

@ychin ychin merged commit a73703f into macvim-dev:master Apr 1, 2021
@ichizok ichizok deleted the fix/xcodeproj branch April 1, 2021 05:02
ychin added a commit to ychin/macvim that referenced this pull request Mar 15, 2023
Part of this was originally part of macvim-dev#1178 but we removed the qlstephen
parts to prepare for eventual removal. Couple years later and we haven't
removed qlstephen yet, so just fix the warnings for now first.

From macvim-dev#1178:

- Fix the project localization name from English to "en"
- Set ALWAYS_SEARCH_USER_PATHS to "NO"

Also:

- Remove the hard-coded macOS 10.8 deployment target which actually
  isn't supported by modern Xcode versions. Just unset it as our CI
  usually sets that for us.
- THe post-build script is now tagged properly to always run.
- Ignore all deprecation warnings. These were exposed because we removed
  the 10.8 deployment target. Since we aren't going to be fixing them
  (we are either just going to grab newer versions from upsteram, or
  delete this), there's no point in having these warnings.
ychin added a commit to ychin/macvim that referenced this pull request Mar 16, 2023
Part of this was originally part of macvim-dev#1178 but we removed the qlstephen
parts to prepare for eventual removal. Couple years later and we haven't
removed qlstephen yet, so just fix the warnings for now first.

From macvim-dev#1178:

- Fix the project localization name from English to "en"
- Set ALWAYS_SEARCH_USER_PATHS to "NO"

Also:

- Remove the hard-coded macOS 10.8 deployment target which actually
  isn't supported by modern Xcode versions. Just unset it as our CI
  usually sets that for us.
- The post-build script is now tagged properly to always run.
- Ignore all deprecation warnings. These were exposed because we removed
  the 10.8 deployment target. Since we aren't going to be fixing them
  (we are either just going to grab newer versions from upsteram, or
  delete this), there's no point in having these warnings.
tono pushed a commit to tono/macvim that referenced this pull request Apr 8, 2023
Part of this was originally part of macvim-dev#1178 but we removed the qlstephen
parts to prepare for eventual removal. Couple years later and we haven't
removed qlstephen yet, so just fix the warnings for now first.

From macvim-dev#1178:

- Fix the project localization name from English to "en"
- Set ALWAYS_SEARCH_USER_PATHS to "NO"

Also:

- Remove the hard-coded macOS 10.8 deployment target which actually
  isn't supported by modern Xcode versions. Just unset it as our CI
  usually sets that for us.
- The post-build script is now tagged properly to always run.
- Ignore all deprecation warnings. These were exposed because we removed
  the 10.8 deployment target. Since we aren't going to be fixing them
  (we are either just going to grab newer versions from upsteram, or
  delete this), there's no point in having these warnings.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants