Fix qlstephen project warnings #1388
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Part of this was originally part of macvim-dev#1178 but we removed the qlstephen parts to prepare for eventual removal. Couple years later and we haven't removed qlstephen yet, so just fix the warnings for now first. From macvim-dev#1178: - Fix the project localization name from English to "en" - Set ALWAYS_SEARCH_USER_PATHS to "NO" Also: - Remove the hard-coded macOS 10.8 deployment target which actually isn't supported by modern Xcode versions. Just unset it as our CI usually sets that for us. - The post-build script is now tagged properly to always run. - Ignore all deprecation warnings. These were exposed because we removed the 10.8 deployment target. Since we aren't going to be fixing them (we are either just going to grab newer versions from upsteram, or delete this), there's no point in having these warnings.
ychin
force-pushed
the
fix-qlstephen-build-warnings
branch
from
48fe271
to
c40d9b4
Compare
ychin
added
the
Non User Facing
tono
pushed a commit
to tono/macvim
that referenced
this pull request
Mar 21, 2023
…nings Fix qlstephen project warnings
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of this was originally part of #1178 but we removed the qlstephen parts to prepare for eventual removal. Couple years later and we haven't removed qlstephen yet, so just fix the warnings for now first.
From #1178:
Also: