Update/job error using this error #66
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
heemankv
changed the base branch from
feat/increasing-test-coverage
to
tests/da-job
Closed
apoorvsadana
reviewed
Aug 2, 2024
cchudant
approved these changes
Aug 5, 2024
crates/orchestrator/src/jobs/mod.rs
Outdated
| fn increment_key_in_metadata( | ||
| metadata: &HashMap<String, String>, | ||
| key: &str, | ||
| ) -> Result<HashMap<String, String>, JobError> { | ||
| let mut new_metadata = metadata.clone(); | ||
| let attempt = get_u64_from_metadata(metadata, key)?; | ||
| let incremented_value = attempt.checked_add(1); | ||
| if incremented_value.is_none() { |
There was a problem hiding this comment.
let Some(incremented_value) = incremented_value else {
return Err(JobError::KeyOutOfBounds { key: key.to_string() }) }
};to avoid the unwrap just after
There was a problem hiding this comment.
or in this case just, incremented_value.ok_or_else(|| JobError::KeyOutOfBounds { key: key.to_string() })?
There was a problem hiding this comment.
Good catch !
Applied.
apoorvsadana
added a commit
that referenced
this pull request
Aug 5, 2024
This reverts commit 519f1d0.
apoorvsadana
added a commit
that referenced
this pull request
Aug 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR solves #65.
thiserrorfor clearer description and syntax of throwing errors.Jobsonly!log::debug!from various places for whichthiserrorerror handling is introduced.Jobare handled, general errors are thrown asOther Errors.