Feature : JobError using thisError #78
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…job_failure_on_small_blob_size
ocdbytes
added a commit
that referenced
this pull request
Oct 16, 2024
* update: added thiserror JobError * update: introducing DaError * update: add ProverJobError * update: Register proof JobError * update: SNOS proof JobError * update: JobError on Queue * update: added fix for borrow in state update process job * update: cleaning rework for JobError * update: wrap_err_with -> wrap_err wherever used with string * update: moved all JobErrors to top of file * update: Errors for consume_job_from_queue * update: linting fixes * update: optimised consume_job_from_queue match statement * update: code optimisation based on PR reviews * chore: lint fixes * chore: lint fixes * update: error matching optimised * update: block_no to String and correct assert on test_da_job_process_job_failure_on_small_blob_size * fix: linting * update: error matching checks * update: test state_update fix * update: test state_update fix * update: test state_update fix * fix: lint * chore: imports fixed * feat : updated the errors enum and implemented OtherTest wrapper for eyre errors * feat : fixed tests --------- Co-authored-by: Arun Jangra <arunjangra1001@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Important : Duplicate PR for #66.
This PR solves #65.
thiserrorfor clearer description and syntax of throwing errors.Jobsonly!log::debug!from various places for whichthiserrorerror handling is introduced.Jobare handled, general errors are thrown asOther Errors.