-
-
Notifications
You must be signed in to change notification settings - Fork 251
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SASS compiler integration #418
Comments
Nice idea! Now we have node base ready, it shouldn't be a hassle :) Lets do it for both SASS ( |
I don't think we should do anything for .sass unless it's super cheap, since there will be no editor support. Also, no one uses .sass anymore. |
Peeps who are in love with CoffeeScript (nifty syntax), do appreciate sass. Would it be possible giving basic syntax highlighting support via WE? |
We can hook node based compilers for both. |
Don't you think they use Stylus instead of |
Yes and that too (also HAML, but that's beside the point) :) Sass and Scss both supports equal syntax. Just differ in style. |
My point is that I'd try to avoid adding larger features for things that less than 3% uses. I believe I'd rather do |
Yes, you are right. SASS is less widespread and low popularity was the main reason they introduced LESS-like scss syntax in first place. So |
We can't really work on this without a ContentType definition. |
No, it's still too early. I'll see what I can do though. We can add a content type definition hidden behind a |
I am figuring out which files to keep in node_modules directory. Each package has different test folders and sometimes more folders for development environment. |
Note that we should do all SASS work in a separate branch so that we don't interfere with releases. |
@madskristensen, duplicate all the |
No, let's keep to this branch |
Why? |
Initial commit for madskristensen#418.
@madskristensen, here we go :) |
Initial commit for madskristensen#418.
Initial commit for madskristensen#418.
Initial commit for madskristensen#418.
@SLaks Because I'm a Git novice and I'm afraid of getting lost. Also, I foresee major merge conflicts when merging the branches |
I guess next we need to:
|
And add unit tests. |
YES! I always envy people who practice TDD. But in our workflow its kind of hard, unless @madskristensen start rejecting PR with missing required tests! :D |
Also refactored code for better classification.
SASS: Added in MarginFactory (Issue #418)
* Maps awaiting sass/node-sass#194. * Error condition dodged sass/node-sass#207.
[UPDATED]
As soon as these are resolved, we will unfix the hacks / tweaks (and sourceMaps would be made functional). Currently, the sourceMaps are inline, like this: /* line 65, C:\Users\Adeel\Documents\Visual Studio 2013\WebSites\WebSite1\1\2\3\cd.scss */
h6 {
font-family: "Segoe UI", Frutiger, "Frutiger Linotype", "Dejavu Sans", "Helvetica Neue", Arial, sans-serif;
font-size: 12px; }
/* line 71, C:\Users\Adeel\Documents\Visual Studio 2013\WebSites\WebSite1\1\2\3\cd.scss */
#main-nav {
background: url('menu_background.png') repeat-x;
min-height: 45px;
margin-bottom: 60px; }
/* line 76, C:\Users\Adeel\Documents\Visual Studio 2013\WebSites\WebSite1\1\2\3\cd.scss */
#main-nav .top-bar {
margin: 0 auto;
background-color: transparent; } Also, formatting is weird. I used Here is the related issue: sass/libsass#233 @madskristensen, this can be closed now. 8-) |
SASS: Fully functional; with tweaks. (Issue #418)
SASS as in
.scss
files and not.sass
.All the features we have for compiling LESS files should be mirrored for SASS compilation as well. Preferably, the compiler should run on nodejs just like LESS and CoffeeScript.
VS2013 will add a SASS editor in an Update soon and WE needs to support it.
Here are the features:
VS takes care of:
These features should be started independent of the VS editor support, to make sure it's ready on time
The text was updated successfully, but these errors were encountered: