This repository has been archived by the owner on Jul 24, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
CLI: Incorrect ERRORLEVEL reported #207
Comments
am11
added a commit
to am11/WebEssentials2013
that referenced
this issue
Jan 5, 2014
* Maps awaiting sass/node-sass#194. * Error condition dodged sass/node-sass#207.
This was referenced Jan 5, 2014
arian
added a commit
to arian/node-sass
that referenced
this issue
Jan 5, 2014
andrew
added a commit
that referenced
this issue
Jan 5, 2014
Fixes #207 - Handle CLI errors, and exit with code 1 if there are errors
@andrew, when is the next release scheduled? |
When I have some free time to build the binaries for each platform, hopefully within the next week |
Cool. Thanks! 👍 |
jiongle1
pushed a commit
to scantist-ossops-m2/node-sass
that referenced
this issue
Apr 7, 2024
Add support for Source Map Revision 3.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
When the compilation fails, node-sass reports incorrect ERRORLEVEL to cmd shell process.
The ERRORLEVEL is always
0
, regardless of process exited with failed compilation. This piece of C# code gets the return from node.js process. The condition is supposed to fail and seek error parsing. Since we are piping StdErr to StdOut, ERRORLEVEL (or .NET's System.Diagnostics.Process.ErrorCode) is the criteria we are relying on. The temporary hack is to check if output file is empty or not, but again that won't work; as some npm's tend to print success messages on StdOut buffer.Please fix the process exit codes. FWIW, we haven't experienced this issue with JsHint, LESS, CoffeeScript and IcedCoffeeScript.
Thanks in anticipation and your patience.
The text was updated successfully, but these errors were encountered: