Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Save image content hash to the media asset when saving image from the Adobe Stock #1494

Closed
sivaschenko opened this issue Jun 18, 2020 · 2 comments · Fixed by #1508
Closed

Save image content hash to the media asset when saving image from the Adobe Stock #1494

sivaschenko opened this issue Jun 18, 2020 · 2 comments · Fixed by #1508
Assignees
@joweecaquicla
Labels
Backend Priority: P2 Should be fixed as early as possible Progress: good first issue Good for newcomers
Milestone
2.1.0

Comments

@sivaschenko
Copy link
Member

sivaschenko commented Jun 18, 2020 •
edited
Loading

Story: #1484

Preconditions (*)

  1. Install Magento 2.4-develop with ASI 2.0-develop
  2. Enable and Configure Adobe Stock Integration in the Stores -> Configuration -> System -> Adobe Stock Integration

Steps to reproduce (*)

  1. Login to Admin panel
  2. Open the media gallery. I.e. from the Catalog -> Category -> Content fieldset -> Select image from gallery
  3. Click "Search Adobe Stock" button
  4. Click on any image to open the image preview panel
  5. Click "Save Preview" button
  6. Confirm the image name in the popup

Expected result (*)

The images information should be saved to the media_gallery_asset table. The hash filed should be populated with the sha1 hash of the image content

Additional info

The same use case should work for Licensing or Saving Licensed image
@sivaschenko sivaschenko added this to the 2.1.0 milestone Jun 18, 2020
@m2-assistant
Copy link

m2-assistant bot commented Jun 18, 2020

Hi @sivaschenko. Thank you for your report.
To help us process this issue please make sure that you provided sufficient information.

Please, add a comment to assign the issue: @magento I am working on this

@sivaschenko sivaschenko added the Priority: P2 Should be fixed as early as possible label Jun 18, 2020
@sivaschenko sivaschenko changed the title Save image content hash to the media asset when saving preview image from the Adobe Stock Save image content hash to the media asset when saving image from the Adobe Stock Jun 18, 2020
@joweecaquicla
Copy link

@magento I am working on this

joweecaquicla pushed a commit to joweecaquicla/adobe-stock-integration that referenced this issue Jun 19, 2020
magento#1494: Save image content hash to the media asset when saving …
507fd78 
…image from the Adobe Stock - implement saving of image content hash to media_gallery_asset table
@joweecaquicla joweecaquicla mentioned this issue Jun 19, 2020
Merged
joweecaquicla pushed a commit to joweecaquicla/adobe-stock-integration that referenced this issue Jun 22, 2020
magento#1494: Save image content hash to the media asset when saving …
f44803e 
…image from the Adobe Stock - fixed failed unit test
@lenaorobei lenaorobei removed this from the 2.1.0 milestone Jun 26, 2020
joweecaquicla pushed a commit to joweecaquicla/adobe-stock-integration that referenced this issue Jul 8, 2020
magento#1494: Save image content hash to the media asset when saving …
85387e2 
…image from the Adobe Stock - modifications for SaveMediaGalleryAsset
joweecaquicla pushed a commit to joweecaquicla/adobe-stock-integration that referenced this issue Jul 8, 2020
magento#1494: Save image content hash to the media asset when saving …
1ef651c 
…image from the Adobe Stock - fix unit test and static test
joweecaquicla pushed a commit to joweecaquicla/adobe-stock-integration that referenced this issue Jul 8, 2020
magento#1494: Save image content hash to the media asset when saving …
49d5133 
…image from the Adobe Stock - fix static test
sivaschenko added a commit that referenced this issue Jul 9, 2020
@sivaschenko
Merge pull request #1508 from joweecaquicla/1494-save-image-content-hash
f8f7257 
#1494: Save image content hash to the media asset when saving image from the Adobe Stock
@lenaorobei lenaorobei added this to the 2.1.0 milestone Jul 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@joweecaquicla joweecaquicla

Labels
Backend Priority: P2 Should be fixed as early as possible Progress: good first issue Good for newcomers
Projects
None yet
Milestone
2.1.0
3 participants
@sivaschenko @lenaorobei @joweecaquicla