#1494: Save image content hash to the media asset when saving image from the Adobe Stock #1508
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…image from the Adobe Stock - implement saving of image content hash to media_gallery_asset table
|
@magento run all tests |
sivaschenko
requested changes
Jun 22, 2020
There was a problem hiding this comment.
Thanks for the pull request @joweecaquicla ! Looks good! Can you please fix the failed unit test
…image from the Adobe Stock - fixed failed unit test
|
@magento run all tests |
coderimus
suggested changes
Jun 29, 2020
There was a problem hiding this comment.
Hi @joweecaquicla ! Thank you for the PR provided 👍 Please, check my change requests below.
joweecaquicla
changed the title
added 4 commits
July 7, 2020 23:18
…ion into 1494-save-image-content-hash
…ion into 1494-save-image-content-hash
…ion into 1494-save-image-content-hash
…image from the Adobe Stock - modifications for SaveMediaGalleryAsset
joweecaquicla
changed the title
|
@magento run all tests |
m2-community-project
bot
added
Progress: review
and removed
Progress: changes requested
labels
…image from the Adobe Stock - fix unit test and static test
|
@magento run all tests |
added 2 commits
July 9, 2020 01:11
…ion into 1494-save-image-content-hash
…image from the Adobe Stock - fix static test
|
@magento run all tests |
sivaschenko
approved these changes
Jul 9, 2020
|
Hi @joweecaquicla, thank you for your contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description (*)
This PR will implement the saving of image content hash to the media asset.
Fixed Issues (if relevant)
Manual testing scenarios (*)
Expected result (*)
The images information should be saved to the
media_gallery_assettable. The hash filed should be populated with thesha1hash of the image content