Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Name and Description fields, from Edit Image window, have not length or allowed symbols validation #1574

Closed
chalov-anton opened this issue Jul 8, 2020 · 2 comments · Fixed by #1586
Closed

Name and Description fields, from Edit Image window, have not length or allowed symbols validation #1574

chalov-anton opened this issue Jul 8, 2020 · 2 comments · Fixed by #1586
Assignees
@jmonteros422
Labels
bug Something isn't working Priority: P1 Needs to be fixed before any other issues Progress: good first issue Good for newcomers Severity: S1 Affects critical data or functionality and forces users to employ a workaround
Milestone
2.1.0

Comments

@chalov-anton
Copy link
Contributor

Precondition (*)

  1. Install Magento with Adobe Stock Integration
  2. Enhanced Media Gallery is Enabled
  3. An image added yo Media Gallery

Steps to reproduce (*)

  1. Go to Content - Media Gallery
  2. Select an image from Media Gallery and click "three dots" in the bottom right
  3. Select Edit
  4. Enter different symbols into Name and Description fields
    validation
  5. Click Save button

Expected result (*)

The image is not saved, the fields should not pass the validation

Actual result (*)

The image is saved
saved_name_validation
@chalov-anton chalov-anton added bug Something isn't working Severity: S1 Affects critical data or functionality and forces users to employ a workaround labels Jul 8, 2020
@chalov-anton chalov-anton added this to the 2.1.0 milestone Jul 8, 2020
@m2-assistant
Copy link

m2-assistant bot commented Jul 8, 2020

Hi @chalov-anton. Thank you for your report.
To help us process this issue please make sure that you provided sufficient information.

Please, add a comment to assign the issue: @magento I am working on this

@chalov-anton
Copy link
Contributor Author

Added high Severity because of Security reasons

@lenaorobei lenaorobei added the Progress: good first issue Good for newcomers label Jul 8, 2020
@sivaschenko sivaschenko added the Priority: P1 Needs to be fixed before any other issues label Jul 8, 2020
@jmonteros422 jmonteros422 reopened this Jul 9, 2020
@jmonteros422 jmonteros422 self-assigned this Jul 9, 2020
jmonteros422 added a commit to jmonteros422/adobe-stock-integration that referenced this issue Jul 9, 2020
@jmonteros422
magento#1574: Name and Description fields, from Edit Image window, ha…
2ca9ac8 
…ve not length or allowed symbols validation - Add native validation to name and description field
@jmonteros422 jmonteros422 mentioned this issue Jul 9, 2020
Merged
jmonteros422 added a commit to jmonteros422/adobe-stock-integration that referenced this issue Jul 10, 2020
@jmonteros422
magento#1574: Name and Description fields, from Edit Image window, ha…
b1b74fc 
…ve not length or allowed symbols validation - Fix static test, remove trailing comma.
sivaschenko added a commit that referenced this issue Jul 13, 2020
@sivaschenko
Merge pull request #1586 from jmonteros422/1574-name-and-description-…
64e3ce8 
…fields-from-edit-image-window-have-not-length-or-allowed-symbols-validation

#1574: Name and Description fields, from Edit Image window, have not length or allowed symbols validation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jmonteros422 jmonteros422

Labels
bug Something isn't working Priority: P1 Needs to be fixed before any other issues Progress: good first issue Good for newcomers Severity: S1 Affects critical data or functionality and forces users to employ a workaround
Projects
None yet
Milestone
2.1.0
4 participants
@sivaschenko @lenaorobei @jmonteros422 @chalov-anton