-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#1574: Name and Description fields, from Edit Image window, have not length or allowed symbols validation #1586
Conversation
…ve not length or allowed symbols validation - Add native validation to name and description field
@magento run all tests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the pull request @jmonteros422 ! Looks good, please see my single comment.
@@ -5,7 +5,7 @@ | |||
*/ | |||
--> | |||
<div class="edit-image-details" if="image"> | |||
<form id="image-edit-details-form" method="post" enctype="multipart/form-data"> | |||
<form data-bind="mageInit:{'validation':{}}" id="image-edit-details-form" method="post" enctype="multipart/form-data"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be better to use a shortcut for mage init:
<form data-bind="mageInit:{'validation':{}}" id="image-edit-details-form" method="post" enctype="multipart/form-data"> | |
<form data-mage-init='{"validation":{}}' id="image-edit-details-form" method="post" enctype="multipart/form-data"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sivaschenko Thank you for reviewing! I tried using the shortcut but this gives me a console error. "Uncaught Error: cannot call methods on validation prior to initialization; attempted to call method 'isValid'".
@jmonteros422 can you please sign the Adobe CLA (in the checks section under the PR) |
…ve not length or allowed symbols validation - Fix static test, remove trailing comma.
…-edit-image-window-have-not-length-or-allowed-symbols-validation
@magento run all tests |
Hi @jmonteros422, thank you for your contribution! |
Need to verify (*)
Description (*)
Fixed Issues (if relevant)
Manual testing scenarios (*)